Page MenuHomePhabricator

Raise $wgMaxImageArea and $wgMaxAnimatedGifArea to highest allowable limit
Closed, ResolvedPublic

Description

Author: mcdevitd

Description:
Half a year ago, in Bug 41125, $wgMaxImageArea and $wgMaxAnimatedGifArea were raised to 25 MP, and there have been no adverse effects. We are likely only talking about a few thousand images remaining that are above that limit, but it continues to be a problem for special areas like complex animations and archival-quality scans, some of which are features images on projects. And this will only become more common with time. I think the raise from 12.5 to 25 was relatively conservative given modern technology. A normal quality archival scan from even 5 years ago was already commonly producing images of 40 MP or more depending on the size of the document (we just don't have many TIFFs in general, so it hasn't seemed like a common problem).

I am wondering if the fact that there are so few of them means we could still render nearly all of the ones on Commons without a problem. Could we just set the arbitrary limit to something very much higher, like 100 or 200, just so no one can do anything too malicious?


Version: wmf-deployment
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=62463

Details

Reference
bz47363

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:16 AM
bzimport set Reference to bz47363.
bzimport added a subscriber: Unknown Object (MLST).

Related URL: https://gerrit.wikimedia.org/r/59925 (Gerrit Change Id6cf5515c55433d1ee502a21e145467bc3222f8f)

(In reply to comment #1)

Related URL: https://gerrit.wikimedia.org/r/59925 (Gerrit Change
Id6cf5515c55433d1ee502a21e145467bc3222f8f)

This changeset bumped both limits to 50MP and was merged.

(In reply to comment #3)

I am not sure if the problem is related, but some large thumbnails do still
not get rendered.

Marco: Might have to do with size.

https://upload.wikimedia.org/wikipedia/commons/thumb/b/bf/Mejeri1.gif/576px-Mejeri1.gif works for me, https://upload.wikimedia.org/wikipedia/commons/thumb/b/bf/Mejeri1.gif/577px-Mejeri1.gif and above does not anymore. Can you confirm?

Worth to file a separate ticket and make it block bug 41371, as bug 9497 is about PNGs and not GIFs. Could you do that?

(In reply to comment #4)

Worth to file a separate ticket and make it block bug 41371, as bug 9497 is
about PNGs and not GIFs. Could you do that?

see bug 48003