Page MenuHomePhabricator

Some student articles are not linked on a course page
Closed, ResolvedPublic

Description

Many of the articles on this course page in the students table are not linked as they should be: https://en.wikipedia.org/wiki/Education_Program:University_of_Utah/Gender_and_Economic_Development_in_the_Third_World_%28Spring_2013%29

I can't figure out anything in particular causing this behavior, and it only affects some of the articles.


Version: master
Severity: normal

Details

Reference
bz47439

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:21 AM
bzimport set Reference to bz47439.
bzimport added a subscriber: Unknown Object (MLST).

Looks like this is the same bug from not so long ago - now the extension will display the page text when it cannot construct the Title from the page id... I guess that for some reason the page id is not set properly, no idea why though.

One easy way to "fix" this is simply linking using the page title text, that might end up being wrong if stuff gets moved around though (not sure this is the case, forgot what MW does with ids on move and delete)

Yeah, looks like this is caused by page moving. No quick fix, will need to look at this a bit

It is not page moving, this is working fine. It is deletion and undeletion that causes a new id to be assigned. Guess we'll need to intercept those events.

I think the ideal behavior would be that if the titled article exists *and* it doesn't match the id, to just switch the id to the new one.

I can think of several situations where a student's article title gets deleted but they would still be working on it: times when the student's first attempt gets deleted but they try again to create an article that will stick, times where page histories from two articles need to be merged (such as if a student forks an article in their sandbox, and an admin does a delete-move-undelete to merge the page histories of the sandbox and main article), and times when there is back-and-forth over the page titles and pages get moved and then moved back over a redirect.

In situations where the article gets deleted and stays deleted, it will be useful to keep the redlink on the course page, so that the instructor and other editors can keep track of what the student had been trying to work on, and have a link to try to recreate the article if desired.


Jeroen, you suggested to simply un-assign the article from all students if it gets deleted. I think that will be really confusing for students and instructors, especially if they don't get notified that their article was deleted. (We can handle this more elegantly once we integrate Echo notifications.) However, if the course pages prompted them to re-add that title (with a message like "Foo no longer exists. Re-add Foo?" [yes][no]) within the Students table, it would be fine.

The current behavior (unlinked titles if the article exists but the id has changed) is not terrible, and I think it has a slight advantage over simply un-assigning articles without some easy way to re-assign the same title anew. In either case, students will have to go through steps to re-assign their article and will need to realize why it got unassigned, but with the current behavior it's easier to see what happened and identify students who need instructions on how to fix the issue.

Now that I understand the circumstances that cause the 'not linked' issue, I'm downgrading the priority; I can document how to work around it and explain to people what to do easily enough.

Ah. So, after the recent updates that fixed the changed-id page errors, you can no longer assign yourself to an article that does not exist. This was not the case before, so many students had assigned themselves redlinks. When those pages subsequently get created (or if they don't exist, now) they are unlinked.

Ok, since this is no longer high prio I'll be doing other things first.

  • This bug has been marked as a duplicate of bug 57608 ***