Page MenuHomePhabricator
Create Task
Maniphest T49452

VisualEditor: "Edit source" tab doesn't become 'active'
Closed, ResolvedPublic
Actions

Description

If in a page you click 'Edit source', the tab does not receive the 'selected' styling/class as it is supposed to.

This was confirmed with Safari 6 mac.

Version: unspecified
Severity: trivial

Details

Reference
bz47452

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:22 AM
• bzimport added projects: VE-deploy-2013-05-13, VisualEditor-MediaWiki.
• bzimport set Reference to bz47452.
TheDJ created this task.Apr 20 2013, 1:18 PM
Catrope added a comment.Apr 26 2013, 5:53 PM

Pretty sure I made this work a couple of weeks ago, but it might have been broken by the more recent changes to this code.

gerritbot added a comment.May 3 2013, 12:18 PM

Related URL: https://gerrit.wikimedia.org/r/62145 (Gerrit Change Ic2d42bb3034be25f388b587a00c3f523cfcc163c)

Jdforrester-WMF added a comment.May 3 2013, 5:40 PM

Now merged and will go live with wmf4.

Jdforrester-WMF added a comment.May 10 2013, 1:55 AM
  • Bug 48316 has been marked as a duplicate of this bug. ***
Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL