Page MenuHomePhabricator

Undefined offset notice in ImageGallery.php if &fileuntil=xxx.yyy is appended on Category: pages
Closed, DeclinedPublic

Description

Author: 02388338eeab

Description:
Specs:
5.4.6-1ubuntu1.2 (fpm-fcgi) - MW 1.20.4 - 10.0.1-MariaDB-mariadb1~quantal-log - Nginx 1.2.1-2.2 - pear.php.net/PEAR-1.9.4 - imagemagick 8:6.7.7.10-2ubuntu4

Error Message:

2013/04/20 14:39:51 [error] 23509#0: *595 FastCGI sent in stderr: "PHP message: PHP Notice: Undefined offset: 3 in /wiki/includes/ImageGallery.php on line 267
PHP message: PHP Notice: Undefined offset: 3 in /wiki/includes/ImageGallery.php on line 267
PHP message: PHP Notice: Undefined offset: 3 in /wiki/includes/ImageGallery.php on line 267
...


Version: 1.21.x
Severity: normal
URL: https://commons.wikimedia.org/wiki/User:Open_Access_Media_Importer_Bot

Details

Reference
bz47464

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:23 AM
bzimport set Reference to bz47464.
bzimport added a subscriber: Unknown Object (MLST).

Thanks for reporting this.

General info: To get better debug information on PHP messages, see http://www.mediawiki.org/wiki/Manual:How_to_debug#PHP_errors

02388338eeab wrote:

Hi,

this error happens only on one Category: (only images) site.
The logfiles of mediawiki shows nothing special "Request ended normally" all image thumbnails in this category show correctly.

Seems like this was an error on my site.

02388338eeab wrote:

(In reply to comment #2)

Hi,

this error happens only on one Category: (only images) site.
The logfiles of mediawiki shows nothing special "Request ended normally" all
image thumbnails in this category show correctly.

Seems like this was an error on my site.

I figured it out.
First: I'm not the only one: https://www.google.de/search?q=Undefined+offset%3A+3+in+includes%2FImageGallery.php+on+line+267&ie=utf-8
Second: This happanes if in a image category &fileuntil=xxx.yyy is appended.

Don't know why. Wiki returns no error. Only php's notice.

I am getting the exact same PHP notice on MW 1.20.7 with PHP 5.3.3 and MySQL 5.1.66 on Apache 2.2.16

piccardi wrote:

I can confirm this error.

I'm using standard Debian packages for Apache, PHP, memcache, apc. From Mediawiki version page I have:

MediaWiki 1.21.2
PHP 5.3.3-7+squeeze17 (apache2handler)
MySQL 5.1.66-0+squeeze1-log

What I find in the error log is:

[Wed Dec 04 11:46:26 2013] [error] [client 217.133.96.194] PHP Notice: Undefined offset: 3 in /var/www/fountainpen.it/mediawiki/includes/ImageGallery.php on line 266

I got this asking for something like:

http://www.fountainpen.it/index.php?title=Categoria:Waterman_Ads&fileuntil=1916-Waterman-4x.jpg.

It happen always when having a category for images with more that 200 images. First you have to go in the second page page by the "next 200" link, then going backby the "previous 200" triggers the error.

The line the notice refers to is the very last line in:

Output each image...

foreach ( $this->mImages as $pair ) {
$nt = $pair[0];
$text = $pair[1]; # "text" means "caption" here
$alt = $pair[2];
$link = $pair[3];

Is this still present on 1.23 ? (I vaugely remember fixing this. Id check myself but only have my phone for the next little while)

piccardi wrote:

I checked on 1.22.6 and it seems resolved. Cannot test 1.23 until is released as stable.

Let's assume it's been fixed (comment 7 and comment 8) in the meantime.

Please reopen if somebody can still reproduce the problem in 1.23.