$wgHandheldStyle not really useful - remove it?
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Apr 22 2013, 12:09 PM

Description

$wgHandheldStyle, added by Brion back in 2008 (dc821ec1 / r38116), it slightly useless - it was only ever implemented for Monobook, and the only use-case given was using Chick's CSS for mobile devices with Monobook being the default skin - and now Chick is no more and Monobook isn't even the default.

Apart from that, it's only used to load styles from [[MediaWiki:Handheld.css]] if it's set (ResourceLoaderSiteModule.php).

Either it should be used consistently for all skins, preferably inside ResourceLoader, or it should be killed off. Personally I'd vote for killing.

Version: 1.22.0
Severity: minor

Details

Reference: bz47504

	Subject	Repo	Branch	Lines +/-
	resourceloader: Remove obsolete logic for handheld=yes pageviews	mediawiki/core	master	+32 -73

Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:26 AM

• bzimport added a project: MediaWiki-User-Interface.

• bzimport set Reference to bz47504.

matmarex created this task.Apr 22 2013, 12:09 PM

Related URL: https://gerrit.wikimedia.org/r/60259 (Gerrit Change Ia8d79b4a637a227eb1879fbb874173fdd9bd6d99)

I have tentatively submitted a patch to remove it at Ia8d79b4a, waiting for input.

Merged

Change 728758 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] resourceloader: Remove obsolete logic for handheld=yes pageviews

https://gerrit.wikimedia.org/r/728758

gerritbot added a project: Patch-For-Review.Oct 9 2021, 1:48 AM

Change 728758 merged by jenkins-bot: