Page MenuHomePhabricator

"test" repository in the tarball does not compile
Closed, ResolvedPublic

Description

$ make
depbase=echo cluster.o | sed 's|[^/]*$|.deps/&|;s|\.o$||';\
g++ -DHAVE_CONFIG_H -I. -I../src -I../include -g -O2 -Wno-long-long -Wall -pedantic -MT cluster.o -MD -MP -MF $depbase.Tpo -c -o cluster.o cluster.cpp &&\
mv -f $depbase.Tpo $depbase.Po
cluster.cpp:25:37: fatal error: cxxtools/unit/testsuite.h: No such file or directory
compilation terminated.
make: *** [cluster.o] Error 1


Version: unspecified
Severity: normal

Details

Reference
bz47577

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:32 AM
bzimport added a project: openZIM-zimlib.
bzimport set Reference to bz47577.

tommi wrote:

The test direcoty contains unit tests based on cxxtools. You need to have cxxtools installed to compile it.

Best way to do it is to run configure with --enable-unittest. The configure check, if cxxtools is available and complains about missing cxxtools if not.

If the tests depend on cxxtools, wouldn't that be better to disable this feature per default?

tommi wrote:

It is disabled by default. It must be explicitly enabled with --enable-unittest.

Then, it's perfect IMO. This "bug" was reported by the Debian packager to me... so I should ask him what exactly was wrong (I can't remember) :(

@Vasudev, are you OK with that? Should we close this ticket as INVALID?

kamathvasudev wrote:

Hi Kelson,

I've no problem with having extra dependency and I enable unit test while building package. The problem which I faced was due to missing linker flag. I've also given a proposed patch for that not sure if it got accepted or not

kamathvasudev wrote:

And here is the bug with patch which I reported https://bugzilla.wikimedia.org/show_bug.cgi?id=48106

  • This bug has been marked as a duplicate of bug 48106 ***