Page MenuHomePhabricator

VisualEditor: Re-label the 'cancel' toolbar message to 'exit without saving'
Closed, DeclinedPublic

Description

The 'cancel' message is used confusingly.

I only noticed it recently. I know of two places where it is used, though there may be more:

  1. As a link near the "Show changes" button when editing a page.
  1. As a button near the "Review and save" button in the VisualEditor.

In both cases it's better to say something like "Exit without saving". The "Cancel" button is usually used in dialog boxes and not in editors' user interfaces.

The message may be used in other places and in extensions, so it's probably better not to change it. For these actions a new message should be created, or maybe even two messages.


Version: unspecified
Severity: trivial

Details

Reference
bz47676

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:39 AM
bzimport added projects: VisualEditor, I18n.
bzimport set Reference to bz47676.

Worry that this is a bit long for users, and "cancel" is used in the dialog sense (they entered an editor, this cancels that edit) but I can see your point.

(BTW, your two descriptions are for the same button, unless I'm missing something?)

I read your concern, Amir, and my opinion is similar to that of James. In computer interaction, clicking a button that says Cancel will end the current action (in this case editing a page) without actually committing the changes that the actor made. I see no deviation from that paradigm in the two use cases you describe.

I think we shoild close this issue without implementing the suggestion made.

Deciding to WONTFIX this, per discussion above. Hopefully it will be more understandable anyway, given the forthcoming changes to the save dialog.

Hehe, it was removed eventually :)