Author: lwelling
Description:
flyout with broken numbering
See screenshot
To reproduce:
Trigger 100 notifications
Look at flyout. Mine said "Showing 7 of 99+"
Close flyout.
Look at flyout. Mine said "Showing 0 of 99+"
That's silly. It's still showing 7.
Version: master
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=44296
Attached:
The text actually says "Showing 0 of 99+ unread" which is correct, its not showing any unread notifications. Which direction is most appropriate to resolve this bug? Possible solutions:
a) Only display unread notifications in the flyout. This would require adjustments in a few different levels (api, backend, possibly a new or adjusted sql index) but is not excessively complicated. Would need to be careful to ensure the query can still be fully resolved through a db index without scanning rows.
b) Adjust text copy. Remove 'unread' from the text and show a count of all notifications. This is probably not very useful though as unread notifications are the one that matter.
c) Adjust text copy. The current text is technically correct, its showing 0 unread notifications. Perhaps some more direct text that says 'Showing 0 unread and 7 read notifications' would clear up the issue.
Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/207
By now, Echo explicitly first finds unread notifications and fills up the rest with read notifications.