Page MenuHomePhabricator

Filter messages from aggregate group when contained group is discouraged for the language
Closed, ResolvedPublic

Description

At the moment, it seems that groups that are not set as priority language for a language, are still part of an aggregate group. Example:

A. A central notice banner group does not have Dutch as priority language. See https://meta.wikimedia.org/w/index.php?title=Special:Translate&language=nl&group=Centralnotice-tgroup-WLPA_alt&filter=&action=translate#msg_WLPA_alt-URL-1

B. This group is part of the aggregate group "CentralNotice Banners": https://meta.wikimedia.org/w/index.php?title=Special:Translate&group=Centralnotice-tgroup&language=nl&filter=!translated&action=translate

Observed:
I. A message like "http://wikilovespublicart.org/english-pages/" is part of the aggregate group in Dutch.

Expected:
II. If groups are discouraged for a language, the messages of those groups should not be part of any aggregate group for that language.


Version: master
Severity: normal

Details

Reference
bz47875

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:23 AM
bzimport set Reference to bz47875.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

Expected:
II. If groups are discouraged for a language, the messages of those groups
should not be part of any aggregate group for that language.

Aggregate groups are not based on languages. So what do you mean by 'aggregate group for a l language'?

We have:
I. translatable page A
II. translatable page B. B can only be translated in language 1.
III. aggregate group C consists of translatable pages A and B.

Expected behavior:
IV: On Special:LanguageStats for language 2, B is not shown as child of C if there are no translations for C.
V: On Special:LanguageStats for language 2, B is shown as child of C if there are translations for C.

Rewriting the above comment with typo fixes as Siebrand told me

We have:
I. translatable page A
II. translatable page B. B can only be translated in language 1.
III. aggregate group C consists of translatable pages A and B.

Expected behavior:
IV: On Special:LanguageStats for language 2, B is not shown as child of C if
there are no translations for B.
V: On Special:LanguageStats for language 2, B is shown as child of C if there
are translations for B.

Case V looks invalid to me, since B is not allowed to have translations in langauge 2 as per II.

In the master, because of Bug 47879 fix, case IV is passing.

If Siebrand confirms case V is invalid, then the bug can be closed

V. is possibly confusing, since we have forced limited languages and advised limited languages. With forced limited languages, the requirement is not valid. With advised limited languages, it is. Apologies for all the potential confusion, but it is a consequence of our large feature set...

Related URL: https://gerrit.wikimedia.org/r/69639 (Gerrit Change Iadfada5004730e9f8cb965aefd4f7105307cc6c5)

Change 69639 abandoned by Santhosh:
Show stats for groups in aggregate group if there are translations

Reason:
Not the correct solution or solution need discussion

https://gerrit.wikimedia.org/r/69639

Nikerabbit claimed this task.

Looking at the code, discouraged translatable pages are excluded from aggregate message groups.