Page MenuHomePhabricator
Create Task
Maniphest T49886

$wgCookieExpiration = 0 doesn't work
Closed, ResolvedPublic
Actions

Description

Setting $wgCookieExpiration = 0 does not, as documented, make all cookies in-session. Rather, it makes all cookies expire 0 second from the server time. This usually does not cause an issue because MediaWiki will load the user from the session instead, but it causes issues with any extensions that use cookies (specifically Extension:SecureSessions). Will have a patch to fix this in Gerrit soon. Maybe this should be backported?

Version: 1.22.0
Severity: normal

Details

Reference
bz47886

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:24 AM
• bzimport added projects: MW-1.22-release, MediaWiki-General.
• bzimport set Reference to bz47886.
Parent5446 created this task.Apr 30 2013, 5:07 PM
Parent5446 added a comment.Apr 30 2013, 5:10 PM

https://gerrit.wikimedia.org/r/61593

Nemo_bis added a comment.Apr 30 2013, 5:14 PM

Correct me if I'm wrong, but this sounds like something that never worked, almost a new feature and definitely not a regression: nice to have but doesn't seem "enough" for a backport so stable.

gerritbot added a comment.Jul 3 2013, 5:39 PM

Change 61593 merged by jenkins-bot:
Fixed $wgCookieExpiration functionality when set to 0.

https://gerrit.wikimedia.org/r/61593

matmarex added a comment.Jul 3 2013, 5:40 PM

Yeah, this never worked. I updated the docs at https://www.mediawiki.org/wiki/Manual:$wgCookieExpiration accordingly.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL