Page MenuHomePhabricator
Create Task
Maniphest T49891

When marking AFD, sends the user two echo notifications
Open, LowPublic
Actions

Description

Description:
Marking a page for deletion results in a posting to user talk page, this triggers two notification: mark for deletion and talk page post.

Description from merged task
In the logs for a page (all logs), speedy deletion tags are logged twice (example). This seems to be because the entry in the deletion tag log is class="mw-logline-pagetriage-deletion" while the page curation log is class="mw-logline-pagetriage-curation". I am told that the tags are only logged if Page Curation is used, but I have not tried to reproduce.

Details

Reference
bz47891

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:24 AM
• bzimport added a project: PageTriage.
• bzimport set Reference to bz47891.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Apr 30 2013, 6:49 PM
• Spage added a comment.Sep 23 2013, 8:42 PM

Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/208

Legoktm added a comment.Oct 18 2013, 7:13 AM

Moving to PageCuration component, it should probably use the BeforeEchoEventInsert hook to abort one of the two notifications.

• werdna unsubscribed.Dec 10 2014, 6:16 PM
Quiddity added a project: Collaboration-Team-Triage.Oct 28 2015, 1:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2015, 1:39 AM
Quiddity merged a task: T86631: Speedy deletion tags logged twice.Aug 17 2016, 9:08 PM
Quiddity added subscribers: Spinningspark, • Mattflaschen-WMF.
Quiddity subscribed.
This comment was removed by Quiddity.
Quiddity updated the task description. (Show Details)Aug 17 2016, 9:09 PM
Quiddity set Security to None.
Spinningspark unsubscribed.Aug 18 2016, 5:56 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 4 2018, 2:30 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 7:05 PM
Aklapper removed a project: Collaboration-Team-Triage.May 25 2021, 9:10 PM
Novem_Linguae subscribed.Jul 17 2022, 9:49 AM
Novem_Linguae renamed this task from Page Curation mark for deletion sends two notifications; use BeforeEchoEventInsert hook to When marking for deletion, logs twice in Special:Log and sends the user two echo notifications.Jul 17 2022, 9:52 AM

This bug's still around in 2022, 10 years later. At first glance, looks like the API call is getting made twice for some reason. Will investigate.

image.png (953×2 px, 327 KB)

Novem_Linguae added a comment.EditedJul 17 2022, 11:17 PM

Two log entries bug - Looking at the code, this is intentional. It makes one entry in the "Page Creation Log" and one entry in the "Deletion Tag Log". It only looks like duplicate entries if you view "All Public Logs". I think this one is a wontfix.

Two notifications bug - Was able to reproduce this for AFD only today. Does not appear to affect CSD or PROD.

2022-07-17_161309.png (848×1 px, 112 KB)

Novem_Linguae renamed this task from When marking for deletion, logs twice in Special:Log and sends the user two echo notifications to When marking AFD, sends the user two echo notifications.EditedJul 19 2022, 1:24 AM
Novem_Linguae mentioned this in T313280: When marking for deletion, logs twice in Special:Log (proposed solution: delete Deletion Tag Log).

I've split the double logging portion of this ticket to T313280. This ticket will now focus on the double notifications for AFDs.

image.png (360×607 px, 40 KB)

Novem_Linguae moved this task from Backlog to Soon on the PageTriage board.Jul 20 2022, 12:38 AM
Novem_Linguae attached a referenced file: F35323031: image.png. (Show Details)Jul 20 2022, 10:15 AM
MPGuy2824 subscribed.Oct 14 2022, 12:13 PM
This comment was removed by MPGuy2824.
Tgr subscribed.Nov 3 2022, 5:58 PM

The talk page message and deletion notifications are of a very different nature, so this feels like expected behavior to me. We do suppress similar notifications in some cases (like when someone writes on your talk page, and also pings you in that same message), but this isn't really such a situation.

Novem_Linguae added a comment.Nov 10 2022, 2:29 AM

I think the fix would be to not trigger the "tagged for deletion" notification if also writing to user talk page. Should be one or the other.

If user is able to not write to user talk page via an option, then we need some kind of check. If user always has to write to user talk page, then we can delete the notification.

Novem_Linguae moved this task from Soon to Other bugs on the PageTriage board.Nov 10 2022, 2:29 AM
Aklapper removed a project: PageTriage.Oct 17 2023, 9:07 PM
Aklapper edited projects, added PageTriage; removed Growth-Team.Oct 17 2023, 9:12 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 17 2023, 9:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL