Page MenuHomePhabricator
Create Task
Maniphest T49920

Add styling for previous/next in SearchTranslations
Closed, ResolvedPublic
Actions

Description

Styling for pagination in SearchTranslations wasn't really done.

Version: master
Severity: normal
URL: https://translatewiki.net/w/i.php?title=Special:SearchTranslations&offset=25&title=Special%3ASearchTranslations&query=test&uselang=en

Details

Reference
bz47920
SubjectRepoBranchLines +/-
Add styling for previous/next in SearchTranslationsmediawiki/extensions/Translatemaster+8 -18
SearchTranslation: changing the styling of pagination linksmediawiki/extensions/Translatemaster+82 -22
SearchTranslation: Add styling for previous/next linksmediawiki/extensions/Translatemaster+21 -5
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:26 AM
• bzimport added a project: MediaWiki-extensions-Translate.
• bzimport set Reference to bz47920.
• bzimport added a subscriber: Unknown Object (MLST).
siebrand created this task.May 1 2013, 8:20 AM
siebrand added a comment.May 1 2013, 8:25 AM

Created attachment 12218
Screenshot of ill styling for pagination links

Steps to reproduce:

  1. Go to URL
  2. Click link "Next results" at the bottom of the search result list
  3. Scroll down to the bottom of the result list

Observed:
I. There are two links: "Previous results" "Next results" and these links do not really stand out compared to for example the "Edit translation" link directly above it.

II. Pagination links are clear and distinguishable from the other links in that area of the page.

Attached:

Schermafbeelding_2013-05-01_om_10.23.30.png (630×756 px, 62 KB)

• bzimport added a comment.Feb 23 2014, 1:19 PM

pr4tiklahoti wrote:

Screenshot of pagination in en.wiki

Screenshot of pagination in en.wiki

Attached:

pagination_in_enwiki.png (106×506 px, 12 KB)

• bzimport added a comment.Feb 23 2014, 1:23 PM

pr4tiklahoti wrote:

How about having the styling and pagination as it is there on en.wiki? Also, a bar saying 'Showing 1-100 of <XYZ> results' at the top would be great.

Nikerabbit moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.Jan 28 2015, 5:42 PM
Nikerabbit added a parent task: T89103: One stop translation search.Feb 11 2015, 7:45 AM
Nemo_bis removed a parent task: T89103: One stop translation search.Feb 11 2015, 3:04 PM
gerritbot subscribed.Mar 9 2015, 5:57 PM

Change 195315 had a related patch set uploaded (by AYUSH GARG):
SearchTranslation: Add styling for previous/next in Search Translations

https://gerrit.wikimedia.org/r/195315

gerritbot added a project: Patch-For-Review.Mar 9 2015, 5:57 PM
AYUSH subscribed.Mar 9 2015, 6:10 PM
gerritbot added a comment.Mar 12 2015, 8:30 PM

Change 196386 had a related patch set uploaded (by AYUSH GARG):
SearchTranslation: Add styling for previous/next links

https://gerrit.wikimedia.org/r/196386

Nemo_bis mentioned this in T89103: One stop translation search.Mar 17 2015, 9:17 AM
gerritbot added a comment.Mar 23 2015, 3:14 PM

Change 198730 had a related patch set uploaded (by Nemo bis):
Add styling for previous/next in SearchTranslations

https://gerrit.wikimedia.org/r/198730

AYUSH mentioned this in T93600: One Stop Translation.Mar 23 2015, 4:24 PM
gerritbot added a comment.Mar 24 2015, 8:37 PM

Change 198730 had a related patch set uploaded (by Nemo bis):
Add styling for previous/next in SearchTranslations

https://gerrit.wikimedia.org/r/198730

gerritbot added a comment.Apr 1 2015, 6:53 PM

Change 196386 merged by jenkins-bot:
SearchTranslation: Add styling for previous/next links

https://gerrit.wikimedia.org/r/196386

AYUSH mentioned this in rMEXTd16b1fa31a0c: Updated mediawiki/extensions Project: mediawiki/extensions/Translate….Apr 1 2015, 6:54 PM
AYUSH mentioned this in rETRAfed499ebfbe2: SearchTranslation: Add styling for previous/next links.
Nikerabbit closed this task as Resolved.Apr 2 2015, 6:08 AM
Nikerabbit claimed this task.
Nikerabbit reassigned this task from Nikerabbit to AYUSH.
Nikerabbit removed a project: Patch-For-Review.
Nikerabbit set Security to None.
gerritbot added a comment.Apr 2 2015, 1:05 PM

Change 195315 abandoned by AYUSH GARG:
SearchTranslation: changing the styling of pagination links

Reason:
not upto the requirement.

https://gerrit.wikimedia.org/r/195315

gerritbot added a comment.Jul 22 2015, 11:01 PM

Change 198730 abandoned by Nikerabbit:
Add styling for previous/next in SearchTranslations

Reason:
Issue has been fixed already.

https://gerrit.wikimedia.org/r/198730

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL