Page MenuHomePhabricator

[INTERLANG] Avoid expand/contract options for language section when list is empty
Closed, ResolvedPublic

Description

When the list of interlanguage list is empty, there should not be an expand/contract triangle at the left since an empty list cannot be expanded and it may give the wrong impression that there are hidden items.


Version: unspecified
Severity: enhancement
Whiteboard: ux
URL: https://nl.wikipedia.org/wiki/Coboldus_nitior?uselang=en
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50004

Details

Reference
bz47973

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:30 AM
bzimport set Reference to bz47973.

I don't think this is a ULS issue, but may be a Vector issue.

If you for example look at URL, you'll see that adding the Wikidata interwiki link editing causes the same behavior, with the possible difference that Wikidata's "Add links" does collapse, and the cog is not supposed to collapse.

  • Bug 50004 has been marked as a duplicate of this bug. ***
  • Bug 50027 has been marked as a duplicate of this bug. ***

I'd prefer we retain this as a place to put an additional access point to "translate this page" Pau its your call whether you think this is a good idea.

(In reply to comment #4)

I'd prefer we retain this as a place to put an additional access point to
"translate this page" Pau its your call whether you think this is a good
idea.

Do I understand correctly this is scope creep/scope change of the original report? If so, I think this should not be done, and a separate feature request should be added.

No, not exactly, as I understood the bug, the desire to either have not language section or have the language section not be expandable and not display the expander toggle.

if we proceed with this bug, my preference would be to remove the control all together, rather than to have a menu item that appears to be broken/non-functional.

my point with the earlier comment was that if Pau intends on having the language control in the left sidebar be an access point for "translate this page" at some point in the future I'd prefer we do not take action on this bug, as we'd have to roll back the changes to get the language tool back again as part of that work, increasing its scope and increasing the amount of change in the UI for users.

Thanks for elaborating, Jared. This doesn't clarify to me what you mean with comment 4. I'll try to summarize how I interpret all previous comments.

  1. (per description and comment 1): Vector works in such a way that each sidebar section is collapsible. ULS adds a section to pages without interlanguage links so that the gear icon needs can be placed there. As a consequence, this causes a collapsible section that collapses or expands 0 items, and may confuse users. This report requests to enhance Vector so that empty sections can exist but will not be collapsible/expandable.
  1. (per comment 4): It is proposed to put the text "translate this page" in this empty section. "translate this page" is an unknown concept in ULS and Vector. It is unclear in which light this is mentioned.

A. It could be that you are proposing to use this section to put a UI text "translate this page" in when we create a feature that makes it possible to translate content of the current wiki to a wiki in another language in the same wiki family (for example from German language Wikipedia to French language Wikipedia). This element would be similar to the Wikidata feature

B. It could refer to the existing "translate this page" UI text that the Translate extension uses for the "page translation" feature on for example Meta-Wiki and mediawiki.org where this text is currently centered at the top of the content[1].

Both options would lead to something similar to the Wikidata feature "Edit links"[2]

There may be option C which I did not consider. In any case, if it's A or B, it would be feature creep on this particular issue, in my opinion, although it's worth discussion both options A and B in as separate issues :).

[1] https://meta.wikimedia.org/wiki/Announcement_Universal_Language_Selector?uselang=en
[2] https://nl.wikipedia.org/wiki/Chromis_amboinensis?uselang=en

  • Bug 50862 has been marked as a duplicate of this bug. ***

The idea of putting "translate this page" ties into the work that Pau is currenltly working on http://pauginer.github.io/prototype-translate/translation-center.html

click "Crete a new translation"

if the user was on the source article in this context we could pre-fill the source article and even guess at the destination language based on the users prefs.

I know this is work in progress but as i said before i'd prefer not to remove this then add it right back.

We could keep the wikidata Edit links item as a top level item within "Language" and add "Translate Article" as soon as there is a working beta of the language translation UI that Pau is working on.

This is "resolved" by not contracting any menu items anymore.