Page MenuHomePhabricator
Create Task
Maniphest T50211

Duplicate ULS dialogs in page source
Closed, ResolvedPublic
Actions

Description

  1. Go to https://dev.translatewiki.net/w/i.php?title=Special:MainPage&uselang=he
  2. Click few input fields (search, search in group selector)
  3. Observe the page source (dynamically updated, not the static one)

Observed: Four or more <div ... class="grid uls-menu uls-wide">...</div>.

Expected: Only one.

Having more than one is usually waste of resources.

Version: master
Severity: normal
Whiteboard: code-quality

Details

Reference
bz48211

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:18 AM
• bzimport added a project: UniversalLanguageSelector.
• bzimport set Reference to bz48211.
Nikerabbit created this task.May 7 2013, 1:29 PM
Nemo_bis added a comment.May 15 2013, 6:07 AM
  • Bug 48423 has been marked as a duplicate of this bug. ***
gerritbot added a comment.May 15 2013, 9:19 AM

Related URL: https://gerrit.wikimedia.org/r/63830 (Gerrit Change I78ad47b1875f9f6f40707fb05f948c939fe91b39)

• santhosh added a comment.May 15 2013, 9:22 AM

Even though we need to avoid unnecessary duplication of ULS windows, please note that depending on context we show different ULS dialogs

  1. One with language settings at the settings block(bottom of dialog
  2. ULS triggered from more languages buttons- without settings icons at the bottom
• santhosh added a comment.May 16 2013, 4:56 AM

(In reply to comment #2)

Related URL: https://gerrit.wikimedia.org/r/63830 (Gerrit Change
I78ad47b1875f9f6f40707fb05f948c939fe91b39)

This was reverted in gerrit 63906 because of a regression

• santhosh added a comment.Jul 24 2013, 11:13 AM

Patch:
https://gerrit.wikimedia.org/r/75564 and https://gerrit.wikimedia.org/r/#/c/75574

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL