Page MenuHomePhabricator

If doing <score raw> and not linking/using midi file, should not require that it be generated
Closed, ResolvedPublic

Description

If you use <score raw>, and don't add a \midi block, then no midi file will be rendered. This generates an error even if the midi file isn't needed. If we don't need the midi file, we should probably not error out in this case (Only issue might be if originally we didn't ask for midi but later changed our mind, since I don't think the midi check happens on a cached hit).


Version: unspecified
Severity: normal

Details

Reference
bz48356

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:28 AM
bzimport set Reference to bz48356.
bzimport added a subscriber: Unknown Object (MLST).
Ebe123 claimed this task.
Ebe123 subscribed.

The bug seems to have been fixed already. There is no error when using <score raw> without a \midi {} block (or if there's a midi block but no midi tag attribute. The only error is if a person uses the attribute without block, which gives score-nomidi and is expected behaviour.

Only issue might be if originally we didn't ask for midi but later changed our mind, since I don't think the midi check happens on a cached hit

The .midi file is created if the block is present. The tag attribute only determines whether to link to it. Adding the block changes the hash and so the midi would exist regardless.

Feel free to re-open this issue if I've missed something, but it seems to be resolved or by-design.