Page MenuHomePhabricator

Remove redundant "patrolmarks" right
Closed, InvalidPublic

Description

Some wikis assign "patrolmarks" right to some group, but the right has no effect: only users with "patrol" permission can see patrol marks, see for instance es.wiki RC where the config is

'*' => array( 'patrolmarks' => true ),

but I can't see any patrol mark. If this ever worked, it now doesn't, so the config should be removed: seems to be trivial cleanup.

For the background: this behaviour makes sense because the others are only bothered by it, however there's a comment by Krinkle in bug 37966 comment 2 which I don't understand (if the right is implied by "patrol" and doesn't work, why assign it?). Siebrand mentioned confusion in bug 19067. At some point FlaggedRevs made all editors see patrol marks, bug 24053 (but this changed after April 2012, compare https://www.mediawiki.org/?oldid=526311 https://www.mediawiki.org/?diff=688799 ).


Version: unspecified
Severity: trivial
URL: https://es.wikipedia.org/wiki/Especial:CambiosRecientes

Details

Reference
bz48370

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:29 AM
bzimport set Reference to bz48370.
bzimport added a subscriber: Unknown Object (MLST).

'patrol' let you patrol pages and see the markers.
'patrolmarks' only let you see the markers.

Markers only shown for pages, which are *not* marked as patrolled. I can see a red ! near to some pages on [[es:Special:RecentChanges]]. But for eswiki only wgUseNPPatrol is true, so you can see that ! only at new pages. The yellow background on [[es:Special:NewPages]] are all unpatrolled pages.

WORKSFORME

Ah, thank you, I now understand Krinkle's "can't be separated". :)
So apart from the confusion with the changes in FlaggedRevs I guess there's no actual problem.