Page MenuHomePhabricator

Remove EmailCapture extension
Closed, ResolvedPublic

Description

From https://noc.wikimedia.org/conf/InitialiseSettings.php.txt:

'wgUseEmailCapture' => array(
	'default' => false,
	'testwiki' => true,
	'enwiki' => true,
),

This variable should be investigated. I'm not sure enwiki and testwiki should be true any longer. At a minimum, it'd be nice to annotate the entry so I'm not left wondering.


Version: wmf-deployment
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=55676

Details

Reference
bz48480

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:36 AM
bzimport set Reference to bz48480.

This is for https://www.mediawiki.org/wiki/Extension:EmailCapture . I don't know if it was ever deployed, but it says it was for the original ArticleFeedback extension.

There's also:

Email capture
NOTE: Must be BEFORE ArticleFeedback
if ( $wgUseEmailCapture ) {
include( "$IP/extensions/EmailCapture/EmailCapture.php" );
$wgEmailCaptureAutoResponse['from'] = 'improve@wikimedia.org';

}

https://noc.wikimedia.org/conf/highlight.php?file=CommonSettings.php

AFAIK this has been disabled for months if not years; it's listed as requirement for AFTv4 at [[mw:Extension:ArticleFeedback]] but not for AFTv5 and IIRC the CTA using EmailCapture didn't last long even though it's mentioned in [[mw:Article_feedback/Version_5/Feature_Requirements]]:
«It may also be possible to adapt the post-survey CTA from AFT v4, with some minor changes to the wording (see this screenshot of a current AFTv4 email capture form, for reference).»
There's no reference to EmailCapture in AFTv5's code and AFTv4 is disabled everywhere:

'wmgUseArticleFeedback' => array(
'default' => false,
),

AFT-related clutter should also be removed from mediawiki/tools/release/make-wmf-branch/default.conf btw.

Change 88424 had a related patch set uploaded by Odder:
(bug 48480) Remove EmailCapture extension settings

https://gerrit.wikimedia.org/r/88424

(In reply to comment #2)

AFT-related clutter should also be removed from
mediawiki/tools/release/make-wmf-branch/default.conf btw.

I'll remove the EmailCapture bit, but will leave ArticleFeedback (v4) be for the time being; we have a lot of code associated with it in CommonSettings.php /and/ InitialiseSettings.php, so it'll need a bug of its own.

Change 88457 had a related patch set uploaded by Odder:
(bug 48480) Clean-up EmailCapture extension config

https://gerrit.wikimedia.org/r/88457

Change 88457 merged by jenkins-bot:
(bug 48480) Clean-up EmailCapture extension config

https://gerrit.wikimedia.org/r/88457

Change 88424 merged by jenkins-bot:
(bug 48480) Remove EmailCapture extension settings

https://gerrit.wikimedia.org/r/88424

Filed bug 55676 to track removing the associated database table from Wikimedia wikis.

Reedy set Security to None.