Scripts are trying to use files from /a/common which doesn't exist on terbium

reedy@terbium:~$ foreachwiki
/usr/local/bin/foreachwikiindblist: line 4: /a/common/all.dblist: No such file or directory

reedy@terbium:~$ cat /usr/local/lib/mw-deployment-vars.sh
MW_COMMON=/usr/local/apache/common-local
MW_COMMON_SOURCE=/a/common
MW_DBLISTS=/usr/local/apache/common-local
MW_DBLISTS_SOURCE=/a/common
MW_CRON_LOGS=/home/wikipedia/logs/norotate
MW_RSYNC_HOST=tin.eqiad.wmnet

mwscript takes care of this for itself:

1. Use the source version of the script if the source directory is present.
2. This only matters if the source dir is shared or when run on the deployment server.

if [ -d "$MW_COMMON_SOURCE" ]; then
MW_COMMON_DIR_USE=$MW_COMMON_SOURCE
else
MW_COMMON_DIR_USE=$MW_COMMON
fi

Current code:

} elsif $system == "scap" {

		$mw_common = "/usr/local/apache/common-local"
		if $::realm == 'production' {
			$mw_common_source = "/a/common"
		} else {
			# For the beta cluster
			$mw_common_source = "/data/project/apache/common-local"
		}
		$dblist_common = $mw_common
		$dblist_common_source = $mw_common_source

}

I guess we need an exception in deployment.pp for terbium, for both of the $*_source variables

Version: wmf-deployment
Severity: normal