Page MenuHomePhabricator

[Lockdown] wgActionLockdown gives incorrect error message
Closed, ResolvedPublic

Description

When I have

$wgActionLockdown['history'] = array('user');

and try to visit action=history, I get the message

You do not have permission to delete this page, for the following reason:
The action you have requested is limited to users in the group: user.

It should say "view the history of" instead of "delete".


Version: unspecified
Severity: minor

Details

Reference
bz48619

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:17 AM
bzimport set Reference to bz48619.
bzimport added a subscriber: Unknown Object (MLST).

uselang=qqx output:

(permissionserrorstext-withaction: 1, (action-delete))

(badaccess-groups: (group-user), 1)

So the code should pass action-history and the admin should create the message on wiki?

Change 131270 had a related patch set uploaded by Ocean behind ears:
Add action-history

https://gerrit.wikimedia.org/r/131270

Change 131272 had a related patch set uploaded by Ocean behind ears:
Replaced hard-coded delete with actual action used.

https://gerrit.wikimedia.org/r/131272

Change 131270 merged by jenkins-bot:
Add action-history

https://gerrit.wikimedia.org/r/131270

@MarkAHershberger is this now with the merged change fixed? If so, please resolve the bug.