Page MenuHomePhabricator

VisualEditor: Toolbar floats only down to the top of the last BranchNode (which isn't always at the end)
Closed, ResolvedPublic

Description

Toolbar in VE floats to position of last BranchNode but should instead just use the bottom of the document or something.


Version: unspecified
Severity: minor

Details

Reference
bz48662

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:20 AM
bzimport set Reference to bz48662.

So the problem is that it lets it go too far or not far enough? I can imagine it somehow, but steps to reproduce the bug would nice.

(In reply to comment #1)

So the problem is that it lets it go too far or not far enough? I can imagine
it somehow, but steps to reproduce the bug would nice.

Doesn't got far enough.

Steps to reproduce: find a document with a very long single BranchNode at the end (or create one). Use VE. Notice that the tool bar slips off the page when you get below the bottom.

Related URL: https://gerrit.wikimedia.org/r/69478 (Gerrit Change I1c7662f2b6f1ced6f80dec16c6ed69a8cc0c06c8)

Fix merged and will go out with next push.