Page MenuHomePhabricator
Create Task
Maniphest T50671

<h5> and <h6> have the same font size at default settings in some skins
Closed, ResolvedPublic
Actions

Description

Browsers tend to have a default font size of 16px and the Vector and Monobook skins use various techniques to end up at 12.8px resp. 12.7px for the bodytext.

Now, in commonElements.css, we have 105% for <h5> and 100% for <h6>. This gives rounded values of 13px for <h5> and <h6> in Vector and Monobook, making them hard to distinguish. (To avoid this, 108% has been used at dewiki for several years.)

Modern is not affected by this problem because it uses browser default font sizes for <hX>. Haven't looked at Cologneblue.

Version: 1.22.0
Severity: minor

Details

Reference
bz48671

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:21 AM
• bzimport added projects: MW-1.22.0-release, MediaWiki-User-Interface, good first task.
• bzimport set Reference to bz48671.
Entlinkt created this task.May 21 2013, 6:45 AM
Entlinkt added a comment.May 22 2013, 7:59 PM

Checked Cologneblue, it OK at the browser default of 16px (h6 ends up at 13.3333px, h5 at 14px and h4 at 14.8px), so only commonElements.css needs to be fixed.

matmarex added a comment.May 29 2013, 8:03 PM

Note that these font-sizes have been changed quite recently in I45bf6e8c (previously they were smaller than body text, which was a little silly). Are you sure 108% was being used? (Or were you also adjusting other heading sizes?)

That said, this seems like an easy bug. Maybe you want to try getting [[developer access]] and fixing it yourself? :)

Entlinkt added a comment.May 30 2013, 12:01 AM

Created attachment 12423
Proposed fix: Enlarge <h5> to 108% in Vector and Monobook

The remark in comment 0 about the 108% at dewiki is about a local adaption in [[de:MediaWiki:Common.css]] that I'm proposing to get upstream with this report.

Attached:

bug48671.patch224 BDownload

matmarex added a comment.Jun 7 2013, 9:58 AM

Since you apparently don't want to do it yourself ;), I submitted your patch to gerrit (noting you as its author): I9d0fccc6.

matmarex added a comment.Jun 13 2013, 10:11 AM

The patch has been merged and will be deployed to Wikimedia wikis per [[MediaWiki 1.22/Roadmap|the roadmap]]. Thanks!

matmarex added a comment.Jun 13 2013, 10:14 AM

[[mw:MediaWiki 1.22/Roadmap]]*

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL