Page MenuHomePhabricator

When saving failed user has no way to retry and even if many failed YOU ARE NOT NOTIFIED
Closed, DuplicatePublic

Description

Original bug title:
When saving failed user has no way to retry and even if many failed YOU ARE NOT NOTIFIED

I just translated
https://commons.wikimedia.org/w/index.php?title=Special:Translate&group=page-Commons%3AWikim%C3%A9dia+France&filter=&action=translate

and somehow my login was lost and "the modification was aborted by an extension hook". I was unable to get it saved and had to open a separate tab and paste each single translation I intended to contribute to Commons.

What makes this that even more worse is this automated scroll down that happens after you saved a translation unit. This way you aren't aware of the issue.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=47184
https://bugzilla.wikimedia.org/show_bug.cgi?id=47119
https://bugzilla.wikimedia.org/show_bug.cgi?id=45555
https://bugzilla.wikimedia.org/show_bug.cgi?id=48804

Details

Reference
bz48773

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:27 AM
bzimport set Reference to bz48773.
bzimport added a subscriber: Unknown Object (MLST).

Developers should probably investigate why that logout happened and in which cases "the modification was aborted by an extension hook" could be triggered (plus what that generic message means).

(In reply to comment #0)

and somehow my login was lost

Getting a warning about it is covered in bug 48775; thanks for filing that.

Yes, this is about a retry button or an automated retry mechanism.

The extension hook was abuse filter which prevented new page creation for anon users. And yes, the error message could be improved but this is the one, the API returns.

Just FYI, when saving fails due to other errors, such as a timeout or a lost internet connection, you are not notified as well.
The "Saving..." notification is shown virtually forever.
Re-editing the message unlocks the save button, but clicking it seems to have no effect.
We lack a (manual) retry mechanism. Maybe that should go to a separate bug?

(In reply to comment #4)

Just FYI, when saving fails due to other errors, such as a timeout or a lost
internet connection, you are not notified as well.
The "Saving..." notification is shown virtually forever.

Sid-G asked be if this is worth a separate report. It is, and it's bug 41466.

As for the rest, this bug report seems a duplicate of bug 47184: due to bug 45894 and friends (TUX tries never to make you wait for loading or saving), it's impossible to give immediate feedback about the result of attempted saving of translation.

Proofreading doesn't have any saved indication and that's bug 45555.

(In reply to comment #5)

As for the rest, this bug report seems a duplicate of bug 47184:

It's useless getting a warning at the end, when trying to close the tab/page if this warning can't include the reason why saving is not done yet. (This is technically not possible)

The extension should immediately display a big bang! "One translation could not be saved because ..." instead of silently ignoring all errors until you want to quit.

The badtoken error is something the translate extension can solve without any user interaction: 1) /w/api.php?action=tokens 2) evaluate whether it is an anon/IP-token or 2a) /w/api.php?meta=userinfo; if LogIn lost proceed as described at Bug 48775#c4 otherwise 3) retry saving.

Sid-G asked be if this is worth a separate report. It is, and it's bug 41466.

The fix for bug 41466 is now merged, and I haven't seen that specific error message since then; the situation did not improve, though. When the request times out, the little tag saying "Saving" changes to "Not saved" (hard to notice), but there is absolutely no way to retry, not even if you change the translation.

This bug makes translating over a slow connection an extremely painful experience.

there is absolutely no way to retry, not even if you change the translation.

Can't reproduce this part reliably, most of the time I can save again after editing. I have definitely seen this the save button get stuck a few times, but I don't know what prompted it.

(In reply to Tisza Gergő from comment #8)

I have definitely seen this the save button get stuck a few times,
but I don't know what prompted it.

I've never seen somethng else - maybe connection speed is a key to the "decision" - or rather the timelyness of a server reply? If so, it would be easily fixed - after the time out that displays "not saved" also unlock the "save" button.

  • This bug has been marked as a duplicate of bug 69314 ***