Page MenuHomePhabricator

Error upgrading MediaWiki from version prior to 1.19 to 1.21
Closed, ResolvedPublic

Description

See URL field.

The update.php script fails:

...batch conversion of user_options: A database query syntax error has occurred. The last attempted database query was: "SELECT rev_id,rev_page,rev_text_id,rev_timestamp,rev_comment,rev_user_text,rev_user,rev_minor_edit,rev_deleted,rev_len,rev_parent_id,rev_sha1,page_namespace,page_title,page_id,page_latest,page_is_redirect,page_len,user_name FROM revision INNER JOIN page ON ((page_id = rev_page)) LEFT JOIN user ON ((rev_user != 0) AND (user_id = rev_user)) WHERE page_id = '9' AND rev_id = '3494' LIMIT 1 " from within function "Revision::fetchFromConds". Database returned error "1054: Unknown column 'rev_sha1' in 'field list' (foobar.barfoo.com)

It's running convertUserOptions.php before creating the rev_sha1 field from revision table.

It calls $user->saveSettings(); (convertUserOptions.php:82) which is doing $this->getUserPage()->invalidateCache(); (User.php:3102) which does $revision = WikiPage::factory( $this )->getRevision(); (Title.php:4517)

update.php needs to be changed to move the rev_sha1 creation before calling
convertUserOptions.php


Version: 1.21.x
Severity: major
URL: https://www.mediawiki.org/wiki/Thread:Project:Support_desk/upgrade_problems:_1.11_--_1.21

Details

Reference
bz49039

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:41 AM
bzimport set Reference to bz49039.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

update.php needs to be changed to move the rev_sha1 creation before calling
convertUserOptions.php

Indeed. I logged a bug for this on the 25th May ;)

  • This bug has been marked as a duplicate of bug 48820 ***