Page MenuHomePhabricator

Page title appears inside <span dir="auto">. it shouldn't (at least in RTL wikis)
Closed, ResolvedPublic

Description

The renderer encloses the main heading of pages inside <span dir="auto">.
this causes display problems on RTL wikis with pages whose name begins with some LTR-script character, and ends with RTL chars. such names are pretty common: for instance, in hewiki, many articles about films, albums, single or songs begin with the movie/song/album name in its original language, and then has (film) or (album) in parens, in cases of ambiguity. of course, this will not be (film) but rather (סרט), and so on and so forth.

the dir="auto" causes the name to be displayed wrong if the browser understands this attribute, e.g., open the page [[he:Californication (אלבום)]]

the page title displays correctly with IE which is too stupid to understand the dir="auto" attribute, but it displays wrong with chrome or FF (which also did not understand this attribute for a long time, but its latest version when i write this, version 21, does understand it).

we should get rid of this dir="auto" in page title. it does not do any good, and it *does* have some bad consequences.

for a long time i thought about this perversion as a chrome bug, and probably other people also thought so, which is why this very old bug was not reported until now. however, when firefox became smarter and started obeying the dir="auto" directive, it became clear that chrome was right all this time, and the bug is in mediawiki page rendering.

please remove it.

peace.


Version: 1.22.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=32403

Details

Reference
bz49093
SubjectRepoBranchLines +/-
mediawiki/skins/Vectormaster+1 -1
mediawiki/skins/Nostalgiamaster+1 -1
mediawiki/skins/Maskmaster+1 -1
mediawiki/skins/apexmaster+1 -1
mediawiki/skins/apexmaster+1 -1
mediawiki/skins/Gamepressmaster+1 -1
mediawiki/skins/DeskMessMirroredmaster+1 -1
mediawiki/skins/DuskToDawnmaster+1 -1
mediawiki/skins/Examplemaster+1 -1
mediawiki/skins/mediawiki-strappingmaster+1 -1
mediawiki/skins/webplatformmaster+1 -1
mediawiki/skins/Duskmaster+1 -1
mediawiki/skins/Bouquetmaster+1 -1
mediawiki/skins/BlueSkymaster+1 -1
mediawiki/skins/Splashmaster+1 -1
mediawiki/skins/MonoBookmaster+1 -1
mediawiki/skins/Modernmaster+1 -1
mediawiki/skins/GreyStuffmaster+1 -1
mediawiki/skins/Daddiomaster+1 -1
mediawiki/skins/CologneBluemaster+1 -1
mediawiki/skins/Metrolookmaster+1 -1
mediawiki/coremaster+1 -1
Show related patches Customize query in gerrit

Related Objects

Mentioned In
rSVEV89fb56dc61ec: Remove dir=auto from firstHeading
rSBLUe2013c80eabb: Remove dir=auto from firstHeading
rSLAT89fb56dc61ec: Remove dir=auto from firstHeading
rSKIN7440e1ac750b: Updated mediawiki/skins Project: mediawiki/skins/webplatform…
rSKINea9eee15aa45: Updated mediawiki/skins Project: mediawiki/skins/Nostalgia…
rSKINffbc0bbd9b9e: Updated mediawiki/skins Project: mediawiki/skins/DuskToDawn…
rSKIN98a554780af7: Updated mediawiki/skins Project: mediawiki/skins/mediawiki-strapping…
rSKIN7d41206422ac: Updated mediawiki/skins Project: mediawiki/skins/Gamepress…
rSKINd57d2bed2103: Updated mediawiki/skins Project: mediawiki/skins/Mask…
rSKINd1669a137b5e: Updated mediawiki/skins Project: mediawiki/skins/Bouquet…
rSKIN9f5bfec58a43: Updated mediawiki/skins Project: mediawiki/skins/DeskMessMirrored…
rSKIN893ebd4c9798: Updated mediawiki/skins Project: mediawiki/skins/Example…
rSKIN268ade66fccb: Updated mediawiki/skins Project: mediawiki/skins/Dusk…
rSKIN0160321bd3b5: Updated mediawiki/skins Project: mediawiki/skins/GreyStuff…
rSKIN8e171bc63c5e: Updated mediawiki/skins Project: mediawiki/skins/Modern…
rSKIN4898348c97a4: Updated mediawiki/skins Project: mediawiki/skins/Splash…
rSKIN7a04d670322b: Updated mediawiki/skins Project: mediawiki/skins/Vector…
rSKIN492be8d3cfad: Updated mediawiki/skins Project: mediawiki/skins/MonoBook…
rSKIN842309899cf1: Updated mediawiki/skins Project: mediawiki/skins/CologneBlue…
rSKIN2a534cd34347: Updated mediawiki/skins Project: mediawiki/skins/Metrolook…
rSKINaa8d0c0ef4c9: Updated mediawiki/skins Project: mediawiki/skins/Daddio…
rSKINb8146088b409: Updated mediawiki/skins Project: mediawiki/skins/BlueSky…
rSMSK5b88ca79327f: Remove dir=auto from firstHeading
rSAPX15c0bbaf589e: Remove dir=auto from firstHeading
rSNOSf85f3a96d5e9: Remove dir=auto from firstHeading
rSSTR17d4ee471c51: Remove dir=auto from firstHeading
rSEXAfde6d88e870a: Remove dir=auto from firstHeading
rSWPLe2916c71aee0: Remove dir=auto from firstHeading
rSDTDdf04941bffe0: Remove dir=auto from firstHeading
rSBOU13401fbad034: Remove dir=auto from firstHeading
rSDMMa3f68fd98367: Remove dir=auto from firstHeading
rSDUS014c48b1e88e: Remove dir=auto from firstHeading
rSSPLf4072f5ca206: Remove dir=auto from firstHeading
rSGPR10d570e5c762: Remove dir=auto from firstHeading
rSBLS475700968c4d: Remove dir=auto from firstHeading
rSMNBd73fa3ba265a: Remove dir=auto from firstHeading
rSVEC89fb56dc61ec: Remove dir=auto from firstHeading
rSCBL08a51899709d: Remove dir=auto from firstHeading
rSMTL52cd193ca981: Remove dir=auto from firstHeading
rSMODf46178577f7f: Remove dir=auto from firstHeading
rSGRYda1b31072c31: Remove dir=auto from firstHeading
rSDADf88ae36d6306: Remove dir=auto from firstHeading
rMW18dbb814ff2b: Remove dir=auto from firstHeading
Mentioned Here
rMW2fde32bed64e: Followup to r105854. Made directionality inline rather than block-level…

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Amire80 set Security to None.

Change 164735 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/164735

I've updated gerrit 63378 to use a real dir based on the title lang instead of dir=auto.

The point is not to base it on the page's languages. That's what happens already. What should be resolved is pages with titles in a language that is different, for example, an English title in an Arabic Wikipedia. Evidently, dir="auto" creates more problems than it resolves so I removed it. Having a separate language for the title would be a solution that I'd love.

Change 187965 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187965

Patch-For-Review

Change 187968 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187968

Patch-For-Review

Change 187969 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187969

Patch-For-Review

Change 187970 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187970

Patch-For-Review

Change 187971 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187971

Patch-For-Review

Change 187972 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187972

Patch-For-Review

Change 187973 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187973

Patch-For-Review

Change 187975 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187975

Patch-For-Review

Change 187976 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187976

Patch-For-Review

Change 187977 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187977

Patch-For-Review

Change 187978 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187978

Patch-For-Review

Change 187979 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187979

Patch-For-Review

Change 187980 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187980

Patch-For-Review

Change 187981 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187981

Patch-For-Review

Change 187982 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187982

Patch-For-Review

Change 187983 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187983

Patch-For-Review

Change 187984 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187984

Patch-For-Review

Change 187985 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187985

Patch-For-Review

Change 187982 abandoned by Ebrahim:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187982

Change 187982 restored by Ebrahim:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187982

Change 187965 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187965

Change 187968 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187968

Change 187969 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187969

Change 187970 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187970

Change 187971 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187971

Change 187972 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187972

Change 187973 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187973

Change 187975 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187975

Change 187976 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187976

Change 187978 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187978

Change 187980 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187980

Change 187983 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187983

Change 187984 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187984

Change 187985 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187985

Change 187981 merged by Isarra:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187981

Change 187979 merged by Isarra:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187979

Change 187977 merged by Isarra:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/187977

Change 188044 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/188044

Patch-For-Review

Change 188044 merged by Bartosz Dziewoński:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/188044

Change 188088 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/188088

Patch-For-Review

Change 188094 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/188094

Patch-For-Review

Change 188094 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/188094

Change 188088 merged by Isarra:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/188088

Change 188101 had a related patch set uploaded (by Ebrahim):
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/188101

Patch-For-Review

Change 188101 merged by jenkins-bot:
Remove dir=auto from firstHeading

https://gerrit.wikimedia.org/r/188101

Ebrahim mentioned this in Unknown Object (Diffusion Commit).