GitInfo.php doesn't like brackets. Gives warning on Special:version
Open, LowPublic
Actions

Assigned To

None

Authored By

	Bawolff
	Jun 4 2013, 1:26 PM

Description

From Special:version:

Warning: syntax error, unexpected ')' in /var/www/w/git/.git/config on line 17
in /var/www/w/git/includes/GitInfo.php on line 173 
 
Warning: Invalid argument supplied for foreach() in /var/www/w/git/includes/GitInfo.php on line 180

Relevant lines of my .git/config:

[merge "mediawikireleasenotes"]

MediaWiki release notes merge driver

driver = ruby $(git rev-parse --git-dir)/mediawikireleasenotes.rb %O %A %B

(The driver line is what is triggering the error)

Version: 1.22.0
Severity: minor

Details

Reference: bz49117

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:46 AM

• bzimport added a project: MediaWiki-Special-pages.

• bzimport set Reference to bz49117.

• bzimport added a subscriber: Unknown Object (MLST).

Bawolff created this task.Jun 4 2013, 1:26 PM

GitInfo uses PHP's parse_ini_file() to parse git's config file, and that file is not an .ini file (even if it's pretty close). I think the exact format is documented in git's manpages, if we want to implement it fully instead of just suppressing the error.

Reusing parse_ini_file() to parse git config also leads to bug 39825.

• Reguyla moved this task from To triage to Special:Version on the MediaWiki-Special-pages board.May 26 2015, 1:56 AM

GitInfo.php doesn't like brackets. Gives warning on Special:versionOpen, LowPublicActions

Description

Details

Event Timeline

GitInfo.php doesn't like brackets. Gives warning on Special:version
Open, LowPublic
Actions