Page MenuHomePhabricator

removeUnusedAccounts.php states that it removes inactive accounts instead
Closed, ResolvedPublic

Description

$ php removeUnusedAccounts.php
Remove unused accounts

Checking for unused user accounts...
Jini
Kevin
...found 239.

Run the script again with --delete to remove them from the database.
$ php removeUnusedAccounts.php --delete
Remove unused accounts

Checking for unused user accounts...
Jini
Remin
...found 239.

Deleting inactive accounts...done.

Hey I meant remove unused accounts not inactive accounts!

Don't give the Sysop a heart attack!


Version: 1.22.0
Severity: minor

Details

Reference
bz49128

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:47 AM
bzimport set Reference to bz49128.

And document what "touched" means!

A massive search finds

  • user_touched should be set to the current time whenever:
  • * the user logs in
  • * the user saves preferences (if no longer default...?)
  • * the user's newtalk status is altered

in maintenance/archives/patch-cache.sql

Change 74327 had a related patch set uploaded by Legoktm:
Change message to say deleting "unused" accounts rather than "inactive".

https://gerrit.wikimedia.org/r/74327

Change 74327 merged by jenkins-bot:
Change message to say deleting "unused" accounts rather than "inactive".

https://gerrit.wikimedia.org/r/74327