Page MenuHomePhabricator

Remove secret.yml file
Closed, ResolvedPublic

Description

Move contents to environment variables. Variables that should be created are mediawiki_password, saucelabs_key and saucelabs_username.

Jenkins already has SAUCE_ONDEMAND_ACCESS_KEY and SAUCE_ONDEMAND_USERNAME variables defined at https://wmf.ci.cloudbees.com/configure


Version: unspecified
Severity: normal

Details

Reference
bz49158

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:49 AM
bzimport set Reference to bz49158.

jhall wrote:

Fix for defining mediawiki_password as an environment variable:

https://github.com/wikimedia/qa-browsertests/pull/9

If that fix is accepted, I'll do an additional fix to address the remaining tasks in this bug (saucelabs_key and saucelabs_username).

Jeff, apologies for the late reply, I was traveling. I have left a couple of comments on the pull request. Please let me know if you need help or if you have any questions.

jhall wrote:

Thanks Željko. That's a great suggestion about outputting a warning if the MEDIAWIKI_PASSWORD variable is not set, and I'll go ahead and work on that next!

Yuvi, any news on gerrit-github script? We need to merge code from github! :)

Change 81927 had a related patch set uploaded by Yuvipanda:
Move mediawiki_password from secret.yml to an environment variable.

https://gerrit.wikimedia.org/r/81927

Change 79793 had a related patch set uploaded by Zfilipin:
Environment variabled determine where the test run

https://gerrit.wikimedia.org/r/79793

Change 79793 merged by Cmcmahon:
Environment variabled determine where the test run

https://gerrit.wikimedia.org/r/79793

Change 82046 had a related patch set uploaded by Zfilipin:
Renamed :cloudbees environment to :saucelabs. Removed ENVIRONMENT environment variable from Jenkins.

https://gerrit.wikimedia.org/r/82046

Change 82049 had a related patch set uploaded by Zfilipin:
Documented how to set up required environment variables

https://gerrit.wikimedia.org/r/82049

Change 82046 merged by Cmcmahon:
Renamed :cloudbees environment to :saucelabs. Removed ENVIRONMENT environment variable from Jenkins.

https://gerrit.wikimedia.org/r/82046

Change 81927 merged by Cmcmahon:
Move mediawiki_password from secret.yml to an environment variable.

https://gerrit.wikimedia.org/r/81927

Change 82049 merged by Cmcmahon:
Documented how to set up required environment variables

https://gerrit.wikimedia.org/r/82049