Implement the URL datatype.
IMPORTANT: Make sure it works nicely with abusefilter and url blacklist.
Version: master
Severity: enhancement
Description
Description
Details
Details
- Reference
- bz49306
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T53113 Formatter for URL datatype | |||
| Resolved | None | T53109 URL datatype UI | |||
| Resolved | None | T51306 implement URL data type in the backend | |||
| Resolved | None | T53621 Make SpamBlacklist aware of ContentHandler |
Event Timeline
Comment Actions
...also, URLs need to be checked against wfUrlProtocols(). Check what the Sanitizer class does to keep evil links out.
Comment Actions
Requirements:
- Validate against wfUrlProtocols() on input
- Sanitize using wfUrlProtocols() etc on output
- Register as external link in ParserOutput
- Make sure it works as expected with SpamBlacklist
- Make sure it works as expected with AbuseFilter
Comment Actions
Change 73993 had a related patch set uploaded by Daniel Kinzler:
(bug 49306) introducing URL data type
Comment Actions
Change 74276 had a related patch set uploaded by Daniel Werner:
(bug 49306) Support for nicer handling of URL data type values in the frontend
Comment Actions
Change 74277 had a related patch set uploaded by Daniel Werner:
(bug 49306) valueview Expert for handling values for URL data type
Comment Actions
Change 74276 abandoned by Daniel Werner:
(bug 49306) Support for nicer handling of URL data type values in the frontend
Comment Actions
Change 74394 had a related patch set uploaded by Daniel Kinzler:
Introducing ReferencedUrlFinder
Comment Actions
Patches I2d26307ad4 and Ia040b891e05 (when merged) complete the backend support for the URL data type, I9ab14abc adds (basic) UI support. Together, these changes should be enough to close this ticket (even though a dedicated backend formatter is still pending).
However, for deployment, we are also blocked on bug 51621: deploying without the SpamBlacklist picking up those links would be quite bad.