Page MenuHomePhabricator

VisualEditor: Rendering of categories fails on first load sometimes in Chrome (Webkit?)
Closed, InvalidPublic0 Estimated Story Points

Description

Instead of "Foo v" you get "Foo
v" - dialog contents render before they're styled because the CSS is slow in coming in (per Roan).


Version: unspecified
Severity: normal

Details

Reference
bz49420

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:07 AM
bzimport set Reference to bz49420.

So there are two somewhat separate (but possibly connected issues) here. One is that, when you load the category dialog on a cold cache (try incognito window) in Chrome, the dialog contents are displayed before they're styled. I can reproduce this on mw.org but not on localhost, presumably because localhost delivers the CSS really fast.

The rendering bug that James is talking about, with the arrow appearing on the next line, only happens in Chrome and only when the flash of unstyled content also happens.

It would be nice if we could block showing the dialog on the CSS loading. The way we load CSS into the dialog iframes should probably be reconsidered anyway.

Per Timo:

Most likely cause of meta dialog's flash of unstyled content:
ve.ui.Dialog.js:
"ve.ui.Dialog.static.addLocalStylesheets( [ 've.ui.Dialog.css' ] );"
Jdforrester-WMF set the point value for this task to 0.
Jdforrester-WMF moved this task from Freezer to TR0: Interrupt on the VisualEditor board.

The code to which this refers has been since adjusted, and I think this is now long-fixed.