Right now, we have to do the following in ve.ui.MWReferenceDialog and ve.ui.MWMediaDialog to set up the sub-editor's surface correctly:
this.referenceSurface.addCommands( ve.init.mw.ViewPageTarget.static.surfaceCommands );
Instead of accessing ve.init.mw (and assuming all surfaces with MW*Dialogs will be instantiated by ve.init.mw.ViewPageTarget), we should just be able to say "initialize this new surface based on this existing surface".
Version: unspecified
Severity: enhancement
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T60270 VisualEditor: <ref> in media item caption in a <ref> isn't blocked, which means page can get into an uneditable state on load | |||
| Resolved | Esanders | T51439 VisualEditor: Surface should be able to inherit commands and toolbar from other surface |
Stylesheets should be inherited as well (and be loaded by the surface rather than the dialog) so we don't have to do things like
ve.ui.MWReferenceDialog.static.addLocalStylesheets( [
've.ce.Node.css',
've.ce.Surface.css',
've.ui.Surface.css',
've.ui.Context.css',
've.ui.Tool.css',
've.ui.Toolbar.css'
] );
Not just inherit, but also block from inheritance for specific instantiations (e.g. the caption of an image inside a reference can't take a reference - bug 58270).