Page MenuHomePhabricator

Cite crash on es:Estadio_Deportivo_Cali
Closed, ResolvedPublic

Description

ERROR: TypeError: Cannot read property 'length' of undefined
Stack trace: TypeError: Cannot read property 'length' of undefined

at RefGroup.add (/home/gabriel/src/mw/extensions/Parsoid/js/lib/ext.Cite.js:171:65)
at References.extractRefFromNode (/home/gabriel/src/mw/extensions/Parsoid/js/lib/ext.Cite.js:326:18)
at generateReferences (/home/gabriel/src/mw/extensions/Parsoid/js/lib/mediawiki.DOMPostProcessor.js:2549:13)
at generateReferences (/home/gabriel/src/mw/extensions/Parsoid/js/lib/mediawiki.DOMPostProcessor.js:2553:5)
at generateReferences (/home/gabriel/src/mw/extensions/Parsoid/js/lib/mediawiki.DOMPostProcessor.js:2553:5)
at generateReferences (/home/gabriel/src/mw/extensions/Parsoid/js/lib/mediawiki.DOMPostProcessor.js:2553:5)
at DOMPostProcessor.doPostProcess (/home/gabriel/src/mw/extensions/Parsoid/js/lib/mediawiki.DOMPostProcessor.js:2819:22)
at [object Object].emit (events.js:67:17)
at [object Object].onEnd (/home/gabriel/src/mw/extensions/Parsoid/js/lib/mediawiki.HTML5TreeBuilder.node.js:76:7)
at SyncTokenTransformManager.emit (events.js:64:17)

Version: unspecified
Severity: normal

Details

Reference
bz49490

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:43 AM
bzimport set Reference to bz49490.

Related URL: https://gerrit.wikimedia.org/r/68219 (Gerrit Change Ib5cf7cce6fa4acd88e3d49ca9d4390a61bfddd7e)

https://gerrit.wikimedia.org/r/68219 (Gerrit Change Ib5cf7cce6fa4acd88e3d49ca9d4390a61bfddd7e) | change APPROVED and MERGED [by jenkins-bot]

This was caused by a ref group named 'constructor'.

Should probably audit the code to see if we store other user-supplied strings in objects without prefixing them.