Page MenuHomePhabricator

Page settings dialog is not oriented for RTL
Closed, ResolvedPublic

Description

The Page settings dialog is not oriented for RTL. The sidebar must be on the right-hand side, the title is supposed to be on the right, the closing X is supposed to be on the left, the Apply settings button is supposed to be on the left, etc.


Version: unspecified
Severity: normal

Details

Reference
bz49613

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:52 AM
bzimport set Reference to bz49613.

Is this "just" an artefact of us not using CSSJanus? See bug 49546.

Related URL: https://gerrit.wikimedia.org/r/69341 (Gerrit Change I418e669b0999552167683352acb365a4249ab9cc)

Change 69341 merged by jenkins-bot:
Dir fix for iframes and widgets

https://gerrit.wikimedia.org/r/69341

Solved. Can be marked as resolved.

Created attachment 12758
screenshot of more problems. issues are marked in red.

It's much better now, thanks!

I found a couple of other small issues:

  1. The icons is the sidebar menu are supposed to be on the right-hand side.
  1. The table headers in the languages menu seem to be aligned to the left. The should be aligned to the right.

Attached:

page-settings-rtl-more-bugs.png (416×837 px, 16 KB)

Change 72115 had a related patch set uploaded by Mooeypoo:
Page settings fix-fix

https://gerrit.wikimedia.org/r/72115

Change 72115 merged by jenkins-bot:
Page settings fix-fix

https://gerrit.wikimedia.org/r/72115

Verified on my test wiki. Thanks!