In VE, new users may use tutorials/wizards which use editintro/preload features, which aren't supported by the visual editor yet.
Description
Description
Details
Details
- Reference
- bz49622
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | DLynch | T51622 Add support for (the equivalent of?) editintro and preload | |||
| Resolved | DLynch | T179063 Clicking on the {{meetupsig}} button not enough for the Save button to be active | |||
| Open | None | T179092 Add support for nosummary parameter |
Event Timeline
There are a very large number of changes, so older changes are hidden. Show Older Changes
Comment Actions
Editintro and preload are parameters supported by the core, but it is "hidden feature", which is exposed natively by InputBox extension (on non native - using external link)
Comment Actions
nominating this as Q1 blocker, since this is closely tied to the current BLP practices on english wikipedia, a very visible and sensitive part of our policies.
Comment Actions
We've encountered this issue too on a private MediaWiki.
Would be really great to have this supported - this would make the VE more versatile in some use cases!
Thanks!
Comment Actions
These tasks *really* shouldn't have been merged, despite being about 'the same' area of code (one is about important functionality half done through on-wiki hacky JavaScript, the other is about modifying a fundamental user pattern in core to work with VisualEditor); un-merging.
Comment Actions
A note from @Tpt that this is pretty important for successful ProofreadPage integration.
Comment Actions
Thomas's suggestion is that if the article is a 404 (non-extant), we sling the contents of preload parameter's indicated article's Parsoid blob as the initial version of the article, and if that's not balanced wikitext (and so not the desired HTML) "oh well", at least it's better than nothing. Thoughts?
Comment Actions
ProofreadPage needs support of the EditFormPreloadText hook instead of editinfo/preload parameters. Tracked by task T138588
Comment Actions
It looks like there are similar problems on Mobile view, which may be of interest to anyone who is relying on preload: T126190: Preload does not work correctly on mobile view
Comment Actions
Change 329796 had a related patch set uploaded (by Esanders):
Add editintro to notices
Comment Actions
Change 378343 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Enable preload in VisualEditor
Comment Actions
That patch is very much the "better than nothing" version James suggested. It pulls the article, substitutes in the parameters, and then if it's in visual mode it runs it through Parsoid. It should be functionally-equivalent for the 2017 wikitext editor, though, since that doesn't rely on always containing valid documents.
Comment Actions
Change 378726 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: Support preloadtitle in source mode
Comment Actions
Change 378726 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: Support preloadtitle in source mode
Comment Actions
Change 378343 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Enable preload in VisualEditor
Comment Actions
What is the best way to test this?
I tried using Template:Submit an edit request on the beta cluster, which appears to use preloading, but it kicked me straight in to the 2010 editor even though I've got the 2017 editor beta feature enabled. I don't even know where I'd begin to test it in the visual editor.
Comment Actions
Ah, that's because I didn't remove preloadtitle from the unsupportedEditParams list.
Note that if you edit the URL to removes just that parameter, it gets the expected result: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Template_talk:Submit_an_edit_request&action=edit&preload=Template%3ASubmit_an_edit_request%2Fpreload&editintro=Template%3AEdit_protected%2Feditintro&preloadparams%5B%5D=&preloadparams%5B%5D=Template%3ASubmit_an_edit_request§ion=new
Comment Actions
Change 379246 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Hooks: remove preloadtitle from unsupported list
Comment Actions
Change 379246 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Hooks: remove preloadtitle from unsupported list
Comment Actions
Just to confirm, now that patch has made its way to the beta cluster, the inputbox button works and gets us this:
Comment Actions
Adding the tag per https://www.mediawiki.org/w/index.php?title=Topic:Tys3st4u4fbxis43 .
Comment Actions
Change 380530 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Api: include preload content when section=new
Comment Actions
Change 380530 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Api: include preload content when section=new