Using ] (closing square bracket) in title tag for external link breaks expected parsing
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ara
	Jun 17 2013, 6:59 AM

Description

When I use 'span title' in external link, MediaWiki are recognized MediaWiki syntax instead of the brackets and showed strange if '[ and ]' are included. e.g. [http://zoo.com/wiki/Talk:Main page <span title="Main Page talk [alt-shift-t]">Discussions about Main Page</span>]

[http://zoo.com/wiki/Talk:Main page <span title="Main Page talk &#91;alt-shift-t&#93;">Discussions about Main Page</span>]

is parsed as

<div class="mw-parser-output"><p><a rel="nofollow" class="external text" href="http://zoo.com/wiki/Talk:Main">page <span title="Main Page talk &#91;alt-shift-t</a>">Discussions about Main Page</span>]
</p></div>

[http://zoo.com/wiki/Talk:Main page <span title="Main Page talk [alt-shift-t]">Discussions about Main Page</span>]

has the same result.

Details

Reference: bz49672

	Subject	Repo	Branch	Lines +/-
	Sanitizer::safeEncodeAttribute(): also encode ]	mediawiki/core	master	+27 -2

Customize query in gerrit

Related Objects

Mentioned In: T181095: Audit Parsoid's handling of wikitext and html strings in HTML attributes
T72875: Links with attributes containing escaped right square brackets don't close properly

Event Timeline

• bzimport raised the priority of this task from to Lowest.Nov 22 2014, 1:56 AM

• bzimport added a project: MediaWiki-Parser.

• bzimport set Reference to bz49672.

• bzimport added a subscriber: Unknown Object (MLST).

Ara created this task.Jun 17 2013, 6:59 AM

Confirming.

Fomafix updated the task description. (Show Details)Nov 16 2017, 3:57 PM

https://gerrit.wikimedia.org/r/391135 solves this problem. The wikitext is rendered then as

<div class="mw-parser-output"><p><a rel="nofollow" class="external text" href="http://zoo.com/wiki/Talk:Main">page <span title="Main Page talk &#91;alt-shift-t&#93;">Discussions about Main Page</span></a>
</p></div>

Change 391135 had a related patch set uploaded (by Fomafix; owner: MaxSem):
[mediawiki/core@master] Sanitizer::safeEncodeAttribute(): also encode ]

https://gerrit.wikimedia.org/r/391135

gerritbot added a project: Patch-For-Review.Nov 16 2017, 5:11 PM

Fomafix merged a task: T72875: Links with attributes containing escaped right square brackets don't close properly.Nov 16 2017, 8:14 PM

Fomafix added subscribers: Jackmcbarn, Anomie.

Fomafix mentioned this in T72875: Links with attributes containing escaped right square brackets don't close properly.Nov 16 2017, 8:18 PM

Change 391135 merged by jenkins-bot:
[mediawiki/core@master] Sanitizer::safeEncodeAttribute(): also encode ]

https://gerrit.wikimedia.org/r/391135

cscott mentioned this in T181095: Audit Parsoid's handling of wikitext and html strings in HTML attributes.Nov 21 2017, 9:20 PM

Fomafix closed this task as Resolved.Nov 25 2017, 10:39 AM

Fomafix assigned this task to MaxSem.

Fomafix raised the priority of this task from Lowest to Low.

Fomafix removed a project: Patch-For-Review.

Aklapper removed subscribers: Anomie, • wikibugs-l-list.Oct 16 2020, 5:43 PM

Using &#93; (closing square bracket) in title tag for external link breaks expected parsingClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Using ] (closing square bracket) in title tag for external link breaks expected parsing
Closed, ResolvedPublic
Actions