Page MenuHomePhabricator

Getting logged out because of logging in on special SUL wikis
Closed, ResolvedPublic

Description

It regularly happens to me that, when I log in on one of the SUL wikis that you absurdly do not get logged into automatically, like chapter wikis or wikimania wikis, after some time I am suddenly logged out globally and need to log in again.


Version: wmf-deployment
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=48646
https://bugzilla.wikimedia.org/show_bug.cgi?id=47843
https://bugzilla.wikimedia.org/show_bug.cgi?id=50130

Details

Reference
bz49708

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:59 AM
bzimport set Reference to bz49708.
bzimport added a subscriber: Unknown Object (MLST).

Dupe of bug 47843?

Also there's a good reason that you can't be auto-loggedin to all *.wikimedia.org wikis. It's not absurd.

(In reply to comment #1)

Dupe of bug 47843?

Maybe related; but on testwiki I am always logged in.
Additionally, re-logging-in on the normal wikis after being logged out there due to logging in on a chapter/wikimania wiki does not log me out on the chapter/wikimania wiki.

Also there's a good reason that you can't be auto-loggedin to all
*.wikimedia.org wikis. It's not absurd.

And this reason is?

(In reply to comment #2)

(In reply to comment #1)

Also there's a good reason that you can't be auto-loggedin to all
*.wikimedia.org wikis. It's not absurd.

And this reason is?

See bug 14407.

(In reply to comment #2)

(In reply to comment #1)

Dupe of bug 47843?

Maybe related; but on testwiki I am always logged in.
Additionally, re-logging-in on the normal wikis after being logged out there
due to logging in on a chapter/wikimania wiki does not log me out on the
chapter/wikimania wiki.

Also there's a good reason that you can't be auto-loggedin to all
*.wikimedia.org wikis. It's not absurd.

And this reason is?

A number of the *.wikimedia.org wikis aren't public, so aren't running SUL. Consequently, SUL can't set a cookie saying you are logged in for *.wikimedia.org.

The correct solution is to move non-SUL wikis out of the *.wikimedia.org domain, but that's unpopular (to which my answer is "tough", but hey).

So why not give the public chapter wikis and wikimania wikis the same setting for logging in as those wikimedia.org wikis that work, such as Meta?

(In reply to comment #4)

A number of the *.wikimedia.org wikis aren't public, so aren't running SUL.
Consequently, SUL can't set a cookie saying you are logged in for
*.wikimedia.org.

I thought it was because of the untrusted sites in *.wikimedia.org that could potentially use cookies which would allow them to impersonate users (e.g. sysadmins, staff, stewards, checkusers, oversighters...) on WMF wikis.

(In reply to comment #5)

So why not give the public chapter wikis and wikimania wikis the same setting
for logging in as those wikimedia.org wikis that work, such as Meta?

(From bug 14407 comment #44)

The "fix" would
be to load an image per target site that's trusted (tim added a few very
common
ones), which would end up with 50+ images to be loaded.. :|

At the current setup, that is upto 65 different images, more in future.
Meaning
probably over 80 images, that's just unacceptable.

Well ok, so this is impossible (which I find absurd!).
But please look into this issue of getting logged out.

testwiki is a special case because CentralAuth uses memcached for sessions, which is not replicated between pmtpa and eqiad.

MF-Warbug, do you use the "keep me logged in" (token based login) when this happens? Just trying to narrow down the variables.

(In reply to comment #9)

MF-Warbug, do you use the "keep me logged in" (token based login) when this
happens? Just trying to narrow down the variables.

I've tried it a few times and it seems like it only/mostly happens when I do not use the option when logging in to the special wiki. (I use it always for the normal SUL login).

(In reply to comment #10)

I've tried it a few times and it seems like it only/mostly happens when I do
not use the option when logging in to the special wiki. (I use it always for
the normal SUL login).

This is presumably because when you log into the special wikis with "keep me logged in" NOT checked, it is overwriting your long-term (30 days) cookies for the other WMF sites with short-term (end of session) ones.

I don't know what the appropriate solution to this is. Do the special wikis really need to be setting cookies for the other sites at all?

Ops moved test.wikipedia.org into eqiad on July 11, so it now has shared memcache with the rest of the servers, and *should* correctly use the correct token. I unfortunately didn't have a reproduction of the bug before they made the change, so can someone verify if this particular bug has been fixed?

After about 3 months of new SUL login methods (or whatever), I think this is fixed; at least I haven't seen it anymore.