Page MenuHomePhabricator

VisualEditor: Template dialog should look up TemplateData for newly-added templates
Closed, ResolvedPublic

Description

Currently in the template dialog when you insert a new template (or other transclusion) it doesn't look up TemplateData for said template (but re-uses if available). It should.


Version: unspecified
Severity: enhancement

Details

Reference
bz49778

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:04 AM
bzimport set Reference to bz49778.

Any movement on this? I note the milestone was yesterday's deploy (if it went out but got reverted with the wmf7 problems, ignore me).

Change 71132 had a related patch set uploaded by Trevor Parscal:
Use template data for new templates

https://gerrit.wikimedia.org/r/71132

Change 71132 merged by jenkins-bot:
Use template data for new templates and fix alias bug

https://gerrit.wikimedia.org/r/71132

Testing on beta, which is using 1.22alpha (3c4aac9) the issue seems to persist:

First I make a new template instance and file one parameter:
http://i.imgur.com/69K7IcD.png

Notice the lack of information

Next I apply changes, and open the template dialog again, and following is shown:
http://i.imgur.com/hV8rqag.png

(In reply to comment #5)

Testing on beta, which is using 1.22alpha (3c4aac9) the issue seems to

This is mediawiki-core. VisualEditor at beta.wmflabs should be currently at f8d2f14 (latest; including merged commit) after Reedy manually updated it (again).

Seems to have been some cache issues, because it seems to be fine now