Page MenuHomePhabricator

[Potential data loss] Error deleting file - A non-identical file already exists at mwstore://...
Closed, ResolvedPublic

Description

Was when deleting [[w:en:File:Remote.jpg]] following message was applied to my eyes:
http://i.imgur.com/AiI58RH.png

The file seems to have been deleted, but I don't know if the error indicates some inconsistencies in the system now.


Version: 1.22.0
Severity: major

Details

Reference
bz49841

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:08 AM
bzimport set Reference to bz49841.
bzimport added a subscriber: Unknown Object (MLST).

Further details from IRC:

17:57] <bawolff> AzaToth: If you got to special:undelete, can you view the version of the file you just deleted?
[17:58] <AzaToth> bawolff: http://en.wikipedia.org/wiki/Special:Undelete/File:Remote.jpg
[17:58] <bawolff> I think the worst case possibility with this error message would be that the file got permenently deleted in a way where the original file is gone
[17:58] <AzaToth> the two images shows the same image, but there was two distinct images when I delted it
[17:59] <AzaToth> it shows only roundcats image
[17:59] <AzaToth> doesn't show xmorgan one from 2006
[17:59] <AzaToth> only the one from 2008
[18:00] <bawolff> So I think one of those images got copied over to the deleted files "section" twice, and one of them got deleted without being copied over to the deleted files store
[18:00] <AzaToth> feature or bug?
[18:01] <AzaToth> bawolff: could it have been the first image was soo old the system didn't cope?
[18:02] <bawolff> I have no idea, possibly.
[18:03] <bawolff> AzaToth: So just to clarify, when you deleted the file right now, was the an image, and a (not-yet deleted) older version of that image. Or was there a single version of that image that wasn't deleted, and previously there had been a deleted image with that filename from way back?
[18:03] <AzaToth> there where two version of the image visible, non deleted
[18:04] <bawolff> ok

Tested on [[test:File:Test-bug49841.jpg]] just to make sure this wasn't some sort of data-loss thing that always happens. I was able to successfully delete/undelete file, so that means AzaToth's issue was either a one-off, or happens intermitently. On one hand that means we aren't loosing data all over the place, on the other it means harder to reproduce/track down.

Was unable to undelete it, getting following message:
Error undeleting file: A non-identical file already exists at "mwstore://local-swift/local-public/archive/4/4c/20080225134441!Remote.jpg"

Special:Undelete shows http://i.imgur.com/4wSUvbi.png

For reference, looks like wrong sha1 in db:

[18:27] <AzaToth> <fa name="Remote.jpg" ns="6" title="File:Remote.jpg" sha1="ceaff3e60757c27fe8f85eb166f6d2b9c61b7ad1" timestamp="2006-04-15T02:20:57Z" size="22414" height="198" width="200" archivename="20080225134441!Remote.jpg" />
[18:27] <AzaToth> <fa name="Remote.jpg" ns="6" title="File:Remote.jpg" sha1="ceaff3e60757c27fe8f85eb166f6d2b9c61b7ad1" timestamp="2008-02-25T13:44:41Z" size="7386" height="116" width="144" />

I guess the real bug here, is that the error deleting the file didn't cause everything to abort and the file to remain not deleted.

Bryan: Did you manage to investigate this at some point, or should the assignee be reset to default and priority put lower on this ticket nowadays?

(In reply to Andre Klapper from comment #5)

Bryan: Did you manage to investigate this at some point, or should the
assignee be reset to default and priority put lower on this ticket nowadays?

This looks to be one of the many bugs that were assigned to me while I was working with the multimedia team. It should probably go back to the default assignee and be picked up by the current team for triage.

*** This bug has been marked as a duplicate of bug 17057 ***

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:23 AM