Page MenuHomePhabricator

VisualEditor: Re-rendered transclusion of blocks comes back as wikitext, not HTML (eww)
Closed, ResolvedPublic

Description

Something's gone wrong with our PHP parser re-render call; on re-render of block templates only, you get {{template call|param}} rather than nice lovely HTML. Presumably something to do with our hack yesterday? Plzfixkthxbai.


Version: unspecified
Severity: major

Details

Reference
bz49854

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:10 AM
bzimport set Reference to bz49854.
  • Bug 49730 has been marked as a duplicate of this bug. ***

Change 70865 had a related patch set uploaded by Esanders:
Fix escapeParams in transclusions to not escape other transclusions

https://gerrit.wikimedia.org/r/70865

Change 70865 merged by jenkins-bot:
Fix escapeParams in transclusions to not escape other transclusions

https://gerrit.wikimedia.org/r/70865

This should now be fixed and we will push it out this afternoon.

  • Bug 50328 has been marked as a duplicate of this bug. ***
  • Bug 50361 has been marked as a duplicate of this bug. ***

I'm not sure if this is the same bug, but English Wikipedia users report that when editing an infobox piped wikilinks display as [[word|word]] rather than as it will appear on save. It saves correctly.

I managed to replicate this. If this should be split off into another bug, sorry!

(In reply to comment #7)

I'm not sure if this is the same bug, but English Wikipedia users report that
when editing an infobox piped wikilinks display as [[word|word]] rather than
as it will appear on save. It saves correctly.

I managed to replicate this. If this should be split off into another bug,
sorry!

That's bug 50801 which we're working on right now; re-closing this one. No worries. :-)