| • Jaredzimmerman-WMF | |
| Jun 20 2013, 6:00 PM |
| F11038: Screen_Shot_2013-07-08_at_11.35.58_AM.png | |
| Nov 22 2014, 1:43 AM |
| F11037: Screen_Shot_2013-06-20_at_3.02.24_PM.png | |
| Nov 22 2014, 1:43 AM |
| F11036: 49896.png | |
| Nov 22 2014, 1:43 AM |
with VE on http://en.wikipedia.org/wiki/Odyssey_Number_Five?veaction=edit media player templates break very badly ( scroll down )
Version: unspecified
Severity: major
URL: http://parsoid.wmflabs.org/en/Odyssey_Number_Five
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50365
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add optional parameter to getAPIData() call | mediawiki/extensions/ParsoidBatchAPI | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | cscott | T56844 Image / media handling (tracking) | |||
| Duplicate | cscott | T51896 In Parsoid and MW API, implement handling for file types that do not have thumbnails, such as audio ogg files | |||
| Resolved | Anomie | T51921 imageinfo API returns incorrect data | |||
| Open | None | T89971 ApiQueryImageInfo is crufty, needs rewrite | |||
| Open | None | T132947 Make it possible for extensions to add additional info to the fileinfo/imageinfo response. | |||
| Declined | None | T134641 Make TextHandler use the timedtext videoinfo api for remoteDB sources | |||
| Open | None | T187759 API is returning 500 status code | |||
| Open | None | T201205 Bad metadata for a single file errors out the complete imageinfo prop request | |||
| Open | None | T235011 API query times out |
Related URL: https://gerrit.wikimedia.org/r/69822 (Gerrit Change I9db6f0c7ab5162801545507bc08e220c7d107e6b)
In response to a request for a thumbnail of at most 220px width the API returns image dimensions of -1 and 2104px for this particular ogg file. This is bug 49921 in core.
Until this is fixed in core we'll try to work around this in Parsoid by rejecting nonsensical dimensions in API responses and forcing dimensions to a sane fallback.
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]
Created attachment 12790
New Weirdness
better but still broken in a different way.
Attached:
The VE interface is currently displaying 'noicon' or 'noplayer' as the caption for
[[Image:En-Birkdale_School.ogg|noicon|200px|center]]
Change 69822 abandoned by Hashar:
(bug 49896) Dirty workaround
Reason:
One year old, I guess this is no more needed / no more apply.
The bug as originally described (T51921) is fixed now. The remaining problem is that Parsoid and the API are effectively assuming that File::transform() will return a ThumbnailImage. But the point of the MediaTransformOutput hierarchy was to allow extensible HTML generation logic, not just customisation of URL/width/height. This flexibility was largely for the benefit of audio/video handling.
Parsoid really needs to be given the MediaTransformOutput subclass name, or something equivalent to it, if it is going to correctly reimplement TimedMediaTransformOutput::toHtml() in JavaScript.
Inside the editor, eventually, yes. However this also would be a concern for read-mode-based-on-Parsoid-HTML, I assume?
A functional player in the Parsoid output would be nice in the long run, but for VE purposes we don't care about that just yet. I'd just like it to be as close to the wikitext output as possible, without necessarily being playable.
Change 550548 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/ParsoidBatchAPI@master] Add optional parameter to getAPIData() call
Change 550548 merged by jenkins-bot:
[mediawiki/extensions/ParsoidBatchAPI@master] Add optional parameter to getAPIData() call
