Page MenuHomePhabricator
Create Task
Maniphest T51898

[TUX] Blacklisted languages are not shown as blacklisted when language was selected using the language selector
Closed, ResolvedPublic
Actions

Description

Original bug title:
When entering the URL generated by the Translate extension into my browser's address bar it says: "Translate in zh please."

But when I choose zh-hant from ULS, it allows translating into Traditional Chinese (zh-hant) and it creates the URL, I later tried to enter in my browser's address bar (which fails with "Translate in zh please.").

Here is the URL: https://commons.wikimedia.org/w/index.php?title=Special:Translate&group=page-Commons%3AVandalism&filter=&action=translate&language=zh-hant

Expected: Consistent behaviour.

See also T124013: Do not allow saving translations to blacklisted language codes

Details

Reference
bz49898
SubjectRepoBranchLines +/-
tux: Change URL when the language is changed through language selectormediawiki/extensions/Translatemaster+8 -39
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:43 AM
• bzimport added a project: MediaWiki-extensions-Translate.
• bzimport set Reference to bz49898.
• bzimport added a subscriber: Unknown Object (MLST).
Rillke created this task.Jun 20 2013, 6:14 PM
Rillke added a comment.Jun 20 2013, 6:21 PM

Note that I use that ULS that appears after clicking the dropdown in Special:Translate

You can easily reproduce this:

On the other hand, go to https://commons.wikimedia.org/w/index.php?title=Special:Translate&group=page-Commons%3AVandalism&filter=&action=translate&language=zh-hant directly and you can't

Nemo_bis added a comment.Jun 20 2013, 6:36 PM

zh-hant is blacklisted, so the warning is correct. However, I was able to save a translation in zh-hant...

liangent added a comment.Jun 20 2013, 7:50 PM

I guess the solution should be to hide disabled languages in Extension:Translate's ULS dialog.

Rillke added a comment.Jun 20 2013, 8:02 PM

Why is zh-hant blacklisted?

liangent added a comment.Jun 20 2013, 8:25 PM

(In reply to comment #4)

Why is zh-hant blacklisted?

There is https://commons.wikimedia.org/w/index.php?title=Commons:Vandalism/zh&variant=zh-hant

liangent added a comment.Jun 20 2013, 8:28 PM

btw. bug 49907 spotted just now.

Nemo_bis added a subscriber: Language-Team.Dec 2 2014, 10:14 AM
Nemo_bis added a project: Language-Team.Dec 2 2014, 10:19 AM
Nemo_bis set Security to None.
Pcoombe subscribed.Jan 23 2015, 11:04 PM
Pcoombe mentioned this in T55641: zh-..., pt, and other language variants are not supported by CentralNotice.Jan 28 2015, 7:57 PM
Nemo_bis added a comment.Feb 28 2015, 2:53 PM

Same issue with invalid locales like "simple": https://translatewiki.net/w/i.php?oldid=6041729&rcid=9644978

Arrbee raised the priority of this task from Medium to High.Jun 4 2015, 9:33 AM
Arrbee moved this task from Backlog to Sprint Backlog on the Language-Team board.
Liuxinyu970226 updated the task description. (Show Details)Aug 11 2015, 12:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2015, 12:22 AM
Liuxinyu970226 mentioned this in T106131: MediaWiki.org should redirect user to appropriate Chinese variant and show them based on preferences.Aug 11 2015, 12:26 AM
Liuxinyu970226 updated the task description. (Show Details)
Nemo_bis added a comment.Aug 31 2015, 5:40 PM

Same with "gom", it's in $wgTranslateBlacklist but language selector offers it and users manage to save https://translatewiki.net/wiki/Thread:Support/Possibility_incorrect_link_in_%27Translate_to%27_language_selector

Nemo_bis mentioned this in T124013: Do not allow saving translations to blacklisted language codes.Jan 20 2016, 9:54 AM
Kaganer subscribed.Jan 20 2016, 12:31 PM
Nikerabbit renamed this task from It's sometimes possible to save translations in a blacklisted language to [TUX] Blacklisted languages are not shown as blacklisted when language was selected using the language selector.Jan 22 2016, 3:46 PM
Nikerabbit updated the task description. (Show Details)
Nikerabbit merged a task: T50804: [TUX] Editor does not handle restricted languages properly.Jan 22 2016, 3:50 PM
Nikerabbit added subscribers: Oriciu, • bzimport, KartikMistry and 9 others.
Nikerabbit moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.Mar 23 2016, 7:27 AM
Arthur2e5 subscribed.May 11 2016, 7:35 PM
Liuxinyu970226 added a subscriber: shinjiman.Jun 23 2016, 3:52 AM
Liuxinyu970226 awarded a token.Jul 15 2016, 12:38 AM
Danny_B removed subscribers: • wikibugs-l-list, Language-Team.Jul 26 2016, 11:47 PM
Liuxinyu970226 added a comment.EditedAug 10 2016, 11:10 PM

I have to invite shinjiman because he said this sentense on Portal talk:Zh of TWN which is very confusing:

By the way MediaWiki never disabled the zh-CN/zh-TW interface so those languages can be translated if the translations are different to their parent language.

I'm afraid, his so-called "can be translated" is also because of this bug

Glaisher mentioned this in T142840: tux does not prevent translations of source language when language is changed through language selector.Aug 12 2016, 4:59 PM
gerritbot subscribed.Aug 26 2016, 5:52 PM

Change 306959 had a related patch set uploaded (by Glaisher):
tux: Change URL when the language is changed through language selector

https://gerrit.wikimedia.org/r/306959

gerritbot added a project: Patch-For-Review.Aug 26 2016, 5:52 PM
• Tbayer unsubscribed.Aug 26 2016, 6:46 PM
gerritbot added a comment.Aug 30 2016, 1:56 PM

Change 306959 merged by jenkins-bot:
tux: Change URL when the language is changed through language selector

https://gerrit.wikimedia.org/r/306959

Glaisher closed this task as Resolved.Aug 30 2016, 3:23 PM
Glaisher claimed this task.
Glaisher subscribed.

T124013: Do not allow saving translations to blacklisted language codes has also been fixed so it won't be possible to make these edits through normal edit page as well.

Liuxinyu970226 unsubscribed.Aug 31 2016, 5:07 AM
Liuxinyu970226 rescinded a token.Oct 1 2016, 12:55 AM
Liuxinyu970226 awarded a token.
LNDDYL subscribed.Apr 18 2017, 2:52 AM
Liuxinyu970226 mentioned this in T172035: Blockers for Wikimedia wiki domain renaming.Apr 18 2018, 4:45 AM
Liuxinyu970226 mentioned this in T193983: Enable zh-my language localization at the Chinese Wikipedia.May 24 2018, 3:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL