Page MenuHomePhabricator

TemplateHandler crashes in nested ref code
Closed, ResolvedPublic

Description

From the production logs:

starting parsing of enwiki:Luis_D._Ortiz
starting parsing of zhwiki:毛西番蓮
http://10.2.2.29/enwiki/Luis_D._Ortiz?oldid=560778411
No cache hit for Luis_D._Ortiz
http://10.2.2.29/zhwiki/毛西番蓮?oldid=26914214
No cache hit for 毛西番蓮

/srv/deployment/parsoid/Parsoid/js/lib/ext.core.TemplateHandler.js:599

dp.tagWidths = [matchInfo[1].length,matchInfo[2].length];
                         ^

TypeError: Cannot read property '1' of null

at TemplateHandler._startTokenPipeline.pipelineOpts.isInclude (/srv/deployment/parsoid/Parsoid/js/lib/ext.core.TemplateHandler.js:599:31)
at TemplateHandler._onChunk (/srv/deployment/parsoid/Parsoid/js/lib/ext.core.TemplateHandler.js:772:2)
at TemplateHandler._startTokenPipeline (/srv/deployment/parsoid/Parsoid/js/lib/ext.core.TemplateHandler.js:589:8)
at ApiRequest._processListeners.processSome (/srv/deployment/parsoid/Parsoid/js/lib/mediawiki.ApiRequest.js:99:17)
at process.startup.processNextTick.process._tickCallback (node.js:244:9)

worker 16497 died (1), restarting.


Version: unspecified
Severity: normal

Details

Reference
bz49916

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:44 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz49916.

Related URL: https://gerrit.wikimedia.org/r/69813 (Gerrit Change I2ba48bd0201bd9d782f7cf19d73c7b1025ab63b2)

https://gerrit.wikimedia.org/r/69813 (Gerrit Change I2ba48bd0201bd9d782f7cf19d73c7b1025ab63b2) | change APPROVED and MERGED [by jenkins-bot]

This is being worked around in production by making up the required information. A proper fix is still needed.

Related URL: https://gerrit.wikimedia.org/r/69837 (Gerrit Change I6d805e5876752d61a3ef4d0872fce8f8a96a9f15)

https://gerrit.wikimedia.org/r/69837 (Gerrit Change I6d805e5876752d61a3ef4d0872fce8f8a96a9f15) | change APPROVED and MERGED [by jenkins-bot]