Page MenuHomePhabricator
Create Task
Maniphest T51943

VisualEditor: "Edit" should load the latest version without hardcoding the "current" revision id (due to race condition and cache)
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. open article in browser window
  2. open same article in another browser window, edit, save changes
  3. edit with VE in first window

Expected result: VE show some sort of warning, and loads the newest version of the article (or maybe refuses to edit it at all).

Actual result: VE happily edits the old revision, and shows [[MediaWiki:Editingold]].

Version: unspecified
Severity: minor

Details

Reference
bz49943

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:47 AM
• bzimport added projects: VE-deploy-2013-07-11, VisualEditor-MediaWiki.
• bzimport set Reference to bz49943.
Tgr created this task.Jun 21 2013, 7:24 AM
gerritbot added a comment.Jul 8 2013, 4:19 PM

Change 72070 had a related patch set uploaded by Krinkle:
mw.ViewPageTarget: Fix incorrect retention of the wrong oldid

https://gerrit.wikimedia.org/r/72070

gerritbot added a comment.Jul 8 2013, 11:16 PM

Change 72070 merged by jenkins-bot:
mw.ViewPageTarget: Fix incorrect retention of the wrong oldid

https://gerrit.wikimedia.org/r/72070

Jdforrester-WMF added a comment.Jul 9 2013, 12:07 AM

This is now deployed and appears to be working as expected in production, according to my testing. Marking as fixed. Please re-open if you find otherwise.

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:18 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL