Page MenuHomePhabricator

Reinstall Extension:ClickTracking on sites with Extension:ArticleFeedback installed
Closed, ResolvedPublic

Description

See bug 49966.

Affected wikis:

'wmgUseArticleFeedback' => array(
'default' => false,
'testwiki' => true,
'eswiki' => true,
'eswikinews' => true,
'hiwiki' => true,
'huwiki' => true,
'metawiki' => true,
'ptwiki' => true,
'ptwikibooks' => true,
'srwiki' => true,
'zhwiki' => true,
),


Version: unspecified
Severity: blocker

Details

Reference
bz49967

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:49 AM
bzimport set Reference to bz49967.

I'm filing this bug assuming this can be done with a simple toggle, while bug 49966 needs come coding work and a full deployment cycle.

AFT team: feel free to reenable ClickTracking today if you believe that is the right course of action to take right now. It's Friday, but, this is breaking and it is known working code.

Sorry for any inconvenience. This appears related to wiki projects that used AFT4, not AFT5, unless I am mistaken.

In any case, there is no need for any clicktracking on either tool, from a product standpoint.

I have contacted our lead developer, Matthias Mullie, so he can chime in from a technical perspective -- and he is Cc:d on this bug.

We are no longer supporting AFT4, and recommend that projects upgrade to AFT5, if you can get community consensus to do so. If your project would like AFT5, please contact us to discuss next steps, after reading this checklist:

http://www.mediawiki.org/wiki/Article_feedback/Version_5/Release_Plan_2013#Checklist

It indeed does not affect AFT5, only AFT.
It does somehow affect the functionality of AFT: at first sight, the links to the signup/login page and the link to edit the page will not work without the clicktracking extension (which tracks the click, then redirects to the correct url, but now probably does not)

I think re-enabling ClickTracking would make sense as a temp-fix. Getting rid of the dependency looks trivial at first sight, so I could do that next week.

Related URL: https://gerrit.wikimedia.org/r/69887 (Gerrit Change I3db3cf47b43d63b167e0397df112341f88eef28a)

So this seems to be about the old (not version 5) version of Article Feedback.
Was there any specific recent code or configuration change?

Because we killed Clicktracking already on April 12th [1], hence wondering if this issue has been existing for more than two months and just nobody cared.

[1] http://lists.wikimedia.org/pipermail/wikitech-l/2013-April/068064.html

I'm fine if someone other than Matthias wants to deploy this clicktracking fix today, but am not sure who would do that.

So unless it's really urgent, could this be deployed next Tuesday, during our regular E2 window?

We're talking about a very old piece of software which we no longer support and should probably discontinue -- then upgrade to AFT5.

Let us know what you recommend.

Gerrit change 69887 (see above) removes the dependency on ClickTracking. If Matthias reviews it, I can deploy it, provided it's OK with Greg.

  • This bug has been marked as a duplicate of bug 49966 ***