Page MenuHomePhabricator

Parsoid: Leading "<" in HTML comment dropped in template inside reference
Closed, ResolvedPublic

Description

Possibly related to wider issues; to investigate.


Version: unspecified
Severity: major
URL: https://en.wikipedia.org/w/index.php?title=Chester_W._Nimitz&diff=561222220&oldid=561222143

Details

Reference
bz50055

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:55 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz50055.

{{echo|foo<!--bar-->quux}}

serialises correctly to:

<p about="#mwt1" typeof="mw:Transclusion" data-mw="{&quot;target&quot;:{&quot;wt&quot;:&quot;echo&quot;,&quot;href&quot;:&quot;./Template:Echo&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;foo<!--bar-->quux&quot;}}}" data-parsoid="{&quot;dsr&quot;:[0,26,null,null],&quot;src&quot;:&quot;{{echo|foo<!--bar-->quux}}&quot;}">fooquux</p>

but then round trips back to:

{{echo|fooquuxbar-->quux}}

where the '<' has been replaced by the contents after the comment.

Related URL: https://gerrit.wikimedia.org/r/70063 (Gerrit Change I0af5889e7bccd0f659df9d4aa1feba9d977d1871)

https://gerrit.wikimedia.org/r/70063 (Gerrit Change I0af5889e7bccd0f659df9d4aa1feba9d977d1871) | change APPROVED and MERGED [by jenkins-bot]

Fixed. Will be deployed later today.