Page MenuHomePhabricator
Create Task
Maniphest T52166

Default whitespace for block templates should be to have a \n beforehand
Closed, ResolvedPublic
Actions

Description

In this revision (normal output, not VE), the navbox looks bugged because it is sitting on the same line as a list item:

http://en.wikipedia.org/w/index.php?title=History_of_Delta_Air_Lines&oldid=561463069#External_links

But VE shows the navbox as if it was on its own line.

This display fault caused a user to save the revision in question, thinking it was formatted properly. VE should probably be leaving block templates on their own line. (Is that another bug?)

Version: unspecified
Severity: normal

Details

Reference
bz50166

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:02 AM
• bzimport added a project: Parsoid.
• bzimport set Reference to bz50166.
TTO created this task.Jun 25 2013, 10:29 AM
Jdforrester-WMF added a comment.Jul 7 2013, 1:30 AM

Retitled this to a Parsoid bug, "Default whitespace for block templates should be to have a \n beforehand" which would solve the issue - but I'm not sure how easy that is for Parsoid to implement?

• GWicke added a comment.Jul 9 2013, 3:13 AM

Is there TemplateData info on what is a block template, and would it be fine to enforce that?

Jdforrester-WMF added a comment.Jul 9 2013, 3:19 AM

(In reply to comment #2)

Is there TemplateData info on what is a block template, and would it be fine
to enforce that?

We could add it, but some templates are block or inline depending on parameters, so…

• GWicke added a comment.Jul 9 2013, 3:23 AM

… or the phase of the moon.

TTO added a comment.Jul 15 2014, 7:30 AM
  • Bug 67268 has been marked as a duplicate of this bug. ***
TTO added a comment.Jul 15 2014, 7:31 AM

Bug 50166 contains a nice example of where this is really important (templates that generate table markup like |- etc).

Arlolra removed • GWicke as the assignee of this task.Nov 25 2014, 8:08 PM
Arlolra set Security to None.
Krinkle unsubscribed.Jan 12 2018, 11:52 PM
LGoto moved this task from Needs Triage to Backlog on the Parsoid board.Feb 17 2020, 4:43 PM
ssastry closed this task as Resolved.May 15 2020, 9:40 PM
ssastry claimed this task.

This 2013 era bug is not longer relevant. We now have TemplateData that specifies format and Parsoid takes care of formatting according to that spec.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL