Page MenuHomePhabricator

VisualEditor: Possible to have links nested inside links
Closed, ResolvedPublic

Description

(Sorry for carelessly filing a dupe before (bug 50207) - I have checked this one, but if it is a dupe, you are most welcome to trout me for wasting your time!)

  1. Edit [[testwiki:VisualEditor:Links]] in VE
  2. Make a selection like

    Golden Gate National Recreation [Area is the] best

    (partly inside the link, partly outside it)
  3. Click the "Link" toolbar button and make a link to any page
  4. Click in the word "Area" to move the cursor there

Two link icons appear in the floating toolbar.

  1. Save page > Review changes

Wikitext output has two links side-by-side, pointing to the same target.


Version: unspecified
Severity: normal

Details

Reference
bz50208

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:05 AM
bzimport set Reference to bz50208.

(In reply to comment #0)

(Sorry for carelessly filing a dupe before (bug 50207) - I have checked this
one, but if it is a dupe, you are most welcome to trout me for wasting your
time!)

Ha, no worries; dupe's aren't in any way useless (it reminds us that it's a real problem we need to fix really soon!). It's mostly just that it's a waste of your time. :-(

  1. Edit [[testwiki:VisualEditor:Links]] in VE
  2. Make a selection like

    Golden Gate National Recreation [Area is the] best

    (partly inside the link, partly outside it)
  3. Click the "Link" toolbar button and make a link to any page
  4. Click in the word "Area" to move the cursor there

Two link icons appear in the floating toolbar.

  1. Save page > Review changes

Wikitext output has two links side-by-side, pointing to the same target.

Yeah, this is definitely a fail on our part (and a regression!). Thanks for the spot; assigning to Ed.

Related URL: https://gerrit.wikimedia.org/r/70644 (Gerrit Change I1cab7f3cc4fc9589eced01ad38c59fe5b9622a57)

Merged and we'll push this to production in the next hour or so.