Page MenuHomePhabricator

VisualEditor: Non-primary edit tab <li> should have class="collapsible"
Closed, ResolvedPublic

Description

Screenshot: Narrow window

When space is scarce (for example at high zoom, or when the window is very narrow), the "View history" tab is moved to the drop-down menu (that also includes "Delete", "Move", etc.) so that the action remains accessible.

The "Edit" and "Edit source" tabs don't seem to do the same; they stay where they are, which prevents them from being used in similar situations (see attached screenshots).

It would imho make sense to migrate both tabs to the drop-down menu as well when there isn't enough space to display them at their usual location, so that users can still access the edit modes.


Version: unspecified
Severity: minor

Attached:

VisualEditor_-_No_edit_button2.png (83×293 px, 10 KB)

Details

Reference
bz50225

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:06 AM
bzimport set Reference to bz50225.

Created attachment 12643
Screenshot: High zoom

Attached:

VisualEditor_-_No_edit_button.png (248×915 px, 25 KB)

(In reply to comment #0)

It would imho make sense to migrate both tabs to the drop-down menu as well
when there isn't enough space to display them at their usual location, so
that
users can still access the edit modes.

"Edit" is not normally collapsed, but it would make sense for "Edit source". You'd just add class="collapsible" on the <li> and it will magically work.

Change 123503 had a related patch set uploaded by Alex Monk:
Give the edit tab <li> closest to the collapsed tabs menu class=collapsible

https://gerrit.wikimedia.org/r/123503

Change 123503 merged by jenkins-bot:
Give the edit tab <li> closest to the collapsed tabs menu class=collapsible

https://gerrit.wikimedia.org/r/123503