Page MenuHomePhabricator

VisualEditor: Have the link inspector inform users if they're linking to a disambiguation or redirect page, or reinserting the same link
Closed, ResolvedPublic

Description

Totally a nice-to-have; it'd be good if the link inspector could inform users that they're linking through to a DAB page.


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50160
https://bugzilla.wikimedia.org/show_bug.cgi?id=59208
https://bugzilla.wikimedia.org/show_bug.cgi?id=49502

Details

Reference
bz50240

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:07 AM
bzimport set Reference to bz50240.

I agree for disambiguation pages.

But I believe creating a wikilink to a redirect page is OK. For instance linking to "HTC Super3" even though it is actually a redirect to "HTC Super".

Sure; I don't think we're saying it shouldn't /let/ the user, merely that it should inform the user.

  • Bug 50986 has been marked as a duplicate of this bug. ***

This has been implemented in the old editor (WikiEditor). See https://gerrit.wikimedia.org/r/#/c/70564/ for the implementation details. It should be easy to add this feature to VisualEditor as well.

This has come up in a discussion about surging numbers of dablinks being noticed by the dab project. If VE is the source for this uptick, we should think about getting this fix in sooner rather than later.

Discussion on en.:
http://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28miscellaneous%29#Disambiguation_in_crisis

The current code related to this functionality is in VisualEditor/modules/ve-mw/ui/widgets/ve.ui.MWLinkTargetInputWidget.js if anyone wants to take a shot at it.

  • Bug 51524 has been marked as a duplicate of this bug. ***

Saehrimnirwikipedia wrote:

Hi is anyone working on this since it is now deployed on more wikipedias this will become a bigger and bigger problem? Before VE people were checking if the Link was going to the right target more often because it was possible to have typos but with a drop down list they are bound to rely that what they pick will work as intended.

Can we also ask that VE warns about "auto-links", which is, links in the article pointing to the article itself? https://bugzilla.wikimedia.org/show_bug.cgi?id=50497 explains why those links can happen, but that is true for templates, I can't recall real reasons for wanting that to happen in the article body as well.
So [[user:Fram]] suggested that a warning would be useful in that case.

Hint: Links to disambig pages can now be easily checked with the isDisambiguationPage() function introduced with Gerrit 100413.

Change 110654 had a related patch set uploaded by Alex Monk:
Mark disambiguation and redirect pages in the link inspector

https://gerrit.wikimedia.org/r/110654

Change 110654 merged by jenkins-bot:
Mark disambiguation and redirect pages in the link inspector

https://gerrit.wikimedia.org/r/110654