UploadWizard has an _epidemic_ unnecessary use of "_this". Let's start using "self" or similar where necessary and "this" where possible.
Version: unspecified
Severity: enhancement
Description
Description
Details
Details
- Reference
- bz50322
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | None | T51987 UploadWizard has some pretty awful code in places (tracking) | |||
| Resolved | MarkTraceur | T52322 Stop using _this, use this |
Event Timeline
Comment Actions
Change 80523 had a related patch set uploaded by MarkTraceur:
Loads of work on jshint fixes
Comment Actions
Still a few more:
$ ack _this -Q -c | grep -v ':0'
resources/jquery/jquery.mwCoolCats.js:14
resources/mw.UploadWizard.js:2
resources/mw.UploadWizardDeed.js:70
resources/mw.UploadWizardDescription.js:14
resources/mw.UploadWizardDetails.js:230
resources/mw.UploadWizardLicenseInput.js:65
resources/mw.UploadWizardUpload.js:83
resources/mw.UploadWizardUploadInterface.js:92
Comment Actions
I wouldn't mind you fixing it - I think mostly they got fixed in the jshint patches, so it shouldn't be necessary, but I wouldn't mind fixing this bug and then moving on to the rest of the jshint things.
Comment Actions
Also notably we changed the policy from being "self" to basically a descriptive word for whatever "this" is in the appropriate scope - e.g. "licenseInput" in a LicenseInput context, "wizard" in an UploadWizard context, "upload" in an UploadWizardUpload context, etc. etc..