Page MenuHomePhabricator

Localisation update broken on 1.22wmf8 and 1.22wmf9
Closed, ResolvedPublic

Description

As reported and first analysed on https://translatewiki.net/w/i.php?title=Thread:Support/How_to_make_edits_visible%3F :

It looks to me like LocalisationUpdate on Wikimedia wikis is broken.

Analysis:

  1. Translation ''Micelnesse gemetu'' at https://translatewiki.net/wiki/MediaWiki:Filehist-dimensions/en of 23:27, 27 June 2013 CEST was added to the source code in
  2. https://gerrit.wikimedia.org/r/#/c/71015/1/languages/messages/MessagesAng.php (line 748) at 28.06.2013 15:47 and is expected to be present on
  3. http://ang.wikipedia.org/wiki/MediaWiki:Filehist-dimensions per
  4. http://ang.wikipedia.org/wiki/Syndrig:Version / 1.22wmf8 and
  5. https://wikitech.wikimedia.org/wiki/Server_admin_log "02:04 logmsgbot: LocalisationUpdate completed (1.22wmf8) at Sat Jun 29 02:03:41 UTC 2013"

But it isn't.

A possibility is that [[MediaWiki:Filehist-dimensions]] was recently changed, and the message is not the same in master as in 1.22wmf8. That's not the case, though. The message is unchanged since at least August 2008 per https://translatewiki.net/w/i.php?title=MediaWiki:Filehist-dimensions/en&action=history

It looks to me like LocalisationUpdate on Wikimedia wikis is broken, as http://www.mediawiki.org/wiki/MediaWiki:Filehist-dimensions/ang also contains the old version of the message content, and mediawiki.org is at 1.22wmf9 per https://www.mediawiki.org/wiki/Special:Version.


Version: wmf-deployment
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49521

Details

Reference
bz50433

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:51 AM
bzimport set Reference to bz50433.
bzimport added a subscriber: Unknown Object (MLST).

Updates for other languages in same commit were also not pushed, e.g. https://gerrit.wikimedia.org/r/#/c/71015/1/languages/messages/MessagesRu.php and [[ru:MediaWiki:Userrights-removed-self]].

I've not checked previous commits nor extensions.

After some preliminary investigation, it looks like dsh isn't actually working. I'll ping ops for help tomorrow.

(In reply to comment #2)

After some preliminary investigation, it looks like dsh isn't actually
working.

What is "dsh"? I'm pretty sure it's not "Domburg Sportprijzen Holland" :).

Distributed shell

Run X command on all servers in group Y

Ori reminded me that bug 50347 got fixed a few hours ago, see https://gerrit.wikimedia.org/r/#/c/71313/
<ori-l> in the process of testing it, he had a few 'fake' scaps (scaps that were supposed to fail and thus abort)
<ori-l> I'm not sure if the log entries siebrand is referring to also correspond to scaps that were engineered to deliberately abort, but they may have. Also, if there *was* an actual problem, it's possible that Tim's change fixed it.

The specific messages mentioned here seem to be working now, but I'm not sure that the underlying problem is actually fixed. When Tim did his scap to test his fix for the other bug, he would have (manually) updated the message files. But the automatic l10nupdate may still be broken.

Change 71525 had a related patch set uploaded by Anomie:
let systemuser l10nupdate have bash as shell so it can run l10nupdate scripts via dsh on new mw* hosts.

https://gerrit.wikimedia.org/r/71525

Change 71525 merged by Tim Starling:
let systemuser l10nupdate have bash as shell so it can run l10nupdate scripts via dsh on new mw* hosts.

https://gerrit.wikimedia.org/r/71525

The change is now deployed, so l10nupdate should now be distributing the updates correctly.

[[fr:MediaWiki:Recentchanges-noresult]] contains last update from https://git.wikimedia.org/blobdiff/mediawiki%2Fcore/a764d99c79d778d46dcbae91800ff678d958a00a/languages%2Fmessages%2FMessagesFr.php so it indeed seems to be working at least for core.

greg lowered the priority of this task from Unbreak Now! to Medium.Jan 8 2015, 5:36 PM
greg moved this task from To Triage to Done on the Deployments board.